Guillaume Desmottes [Tue, 8 Nov 2011 15:05:15 +0000 (16:05 +0100)]
Remove obsolete contact-list-{store,view}
Hourrah \o/
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Tue, 8 Nov 2011 15:02:19 +0000 (16:02 +0100)]
remove EmpathyContactManager's test
We want to get rid of it any way.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Mon, 7 Nov 2011 09:55:39 +0000 (10:55 +0100)]
chat: use the individual view/store rather than the contact one
The great unification !
EmpathyChat was the last user of the contact store/view, everything now use
the individual ones.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Tue, 22 Nov 2011 09:04:40 +0000 (10:04 +0100)]
add initial_loading() as a virtual method
This allows us to remove setup_idle_id as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Tue, 22 Nov 2011 09:04:40 +0000 (10:04 +0100)]
add empathy_individual_store_refresh_individual() as a protected method
This allows us to remove show_active as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Tue, 8 Nov 2011 14:00:30 +0000 (15:00 +0100)]
Add individual-store-channel
This will allow us to use the individual view to display muc members.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Tue, 8 Nov 2011 13:06:49 +0000 (14:06 +0100)]
add EMPATHY_INDIVIDUAL_FEATURE_ADD_CONTACT
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Fri, 4 Nov 2011 12:45:38 +0000 (13:45 +0100)]
factor out empathy_create_individual_from_tp_contact()
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Fri, 4 Nov 2011 11:15:47 +0000 (12:15 +0100)]
Abstract the individual store
We now have EmpathyIndividualStoreManager which implements the store using
EmpathyIndividualManager as its contact source.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Fri, 4 Nov 2011 10:35:46 +0000 (11:35 +0100)]
individual-store: expose some attributes and methods as 'protected'
This will be needed when abstracting EmpathyIndividualStore.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
Guillaume Desmottes [Wed, 2 Nov 2011 13:48:23 +0000 (14:48 +0100)]
Allow user to try another password if auth failed
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Wed, 2 Nov 2011 13:41:56 +0000 (14:41 +0100)]
add empathy-bad-password-dialog
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Fri, 28 Oct 2011 13:00:40 +0000 (15:00 +0200)]
auth-factory: relay the auth-password-failed signal
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Fri, 28 Oct 2011 12:56:58 +0000 (14:56 +0200)]
server-sasl-handler: add auth-password-failed signal
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Fri, 28 Oct 2011 14:34:40 +0000 (16:34 +0200)]
Abstract EmpathyPasswordDialog to EmpathyBasePasswordDialog
I'm going to implement a slidely different version of this dialog so best to
re-use as much code as possible.
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Fri, 28 Oct 2011 13:27:55 +0000 (15:27 +0200)]
password-dialog: use self->priv pattern
https://bugzilla.gnome.org/show_bug.cgi?id=661640
Guillaume Desmottes [Mon, 21 Nov 2011 12:50:14 +0000 (13:50 +0100)]
restart the camera only if it's already running
Always restarting it will enable the camera in an audio only call.
https://bugzilla.gnome.org/show_bug.cgi?id=664459
Guillaume Desmottes [Mon, 21 Nov 2011 10:43:51 +0000 (11:43 +0100)]
factor out empathy_call_window_change_webcam()
https://bugzilla.gnome.org/show_bug.cgi?id=664459
Arun Raghavan [Mon, 21 Nov 2011 17:57:08 +0000 (23:27 +0530)]
audio-src,audio-sink: Use lower latency values on pulsesrc/pulsesink
This sets the pulsesink and pulsesrc buffer/latency parameters to be
lower and more voip-friendly. If the system cannot provide or keep up
with these values, PulseAudio will automatically try to adapt and
provide larger values that are achievable.
https://bugzilla.gnome.org/show_bug.cgi?id=663124
Guillaume Desmottes [Mon, 21 Nov 2011 15:56:01 +0000 (16:56 +0100)]
remove released flag
Guillaume Desmottes [Mon, 7 Nov 2011 16:45:28 +0000 (17:45 +0100)]
sync gsettings.m4
Latest version of glib-compile-schemas removed the --uninstall option; trying
to use it break "make distcheck".
Guillaume Desmottes [Mon, 21 Nov 2011 15:32:43 +0000 (16:32 +0100)]
prepare 3.3.2
Ken VanDine [Mon, 21 Nov 2011 13:58:52 +0000 (14:58 +0100)]
set_size_request on the video_container to ensure the window has a sane minimum size.
https://bugzilla.gnome.org/show_bug.cgi?id=664313
Guillaume Desmottes [Mon, 21 Nov 2011 10:22:52 +0000 (11:22 +0100)]
fix GTK_BOX casts
Guillaume Desmottes [Wed, 16 Nov 2011 16:07:51 +0000 (17:07 +0100)]
use gtk_box_new() instead of gtk_[h,v]box_new()
https://bugzilla.gnome.org/show_bug.cgi?id=662903
Guillaume Desmottes [Wed, 16 Nov 2011 15:34:47 +0000 (16:34 +0100)]
use gtk_paned_new() instead of gtk_hpaned_new()
https://bugzilla.gnome.org/show_bug.cgi?id=662903
Guillaume Desmottes [Wed, 16 Nov 2011 15:32:14 +0000 (16:32 +0100)]
use gtk_separator_new() instead of gtk_hseparator_new()
https://bugzilla.gnome.org/show_bug.cgi?id=662903
Algimantas Margevičius [Fri, 18 Nov 2011 20:42:12 +0000 (22:42 +0200)]
Updated Lithuanian translation
Sjoerd Simons [Fri, 18 Nov 2011 17:02:39 +0000 (17:02 +0000)]
Bump telepathy-farstream requirement
Sjoerd Simons [Fri, 18 Nov 2011 10:48:15 +0000 (10:48 +0000)]
AudioSink: Setup the initial properties in the main thread
Sjoerd Simons [Fri, 18 Nov 2011 10:05:57 +0000 (10:05 +0000)]
Call: Bind the output properties from the main thread
If we bind and sync the output volume from the non-main thread, we end
up calling gtk and clutter from the non-main thread.. Which leads to
crashes in OpenGL drivers and potenially kills your cat. Instead create
the audio output when the audio content is added, which happens from the
main thread. The output element is still only added to gstreamer
pipeline when needed though.
Sjoerd Simons [Thu, 17 Nov 2011 19:45:39 +0000 (19:45 +0000)]
Bind the volume button to the volume of the output
Sjoerd Simons [Thu, 17 Nov 2011 19:29:21 +0000 (19:29 +0000)]
Bind the mic button the sources mute property
Sjoerd Simons [Thu, 17 Nov 2011 20:14:01 +0000 (20:14 +0000)]
Remove call input volume configuration
As we rely on pulseaudio there is no point in saving our own volume
configuration, pulseaudio does that for us. If we do save it, then we
have no idea which volume to pick after connecting to pulse (the one we
save, the one pulse saved, a random value?).
On top of that our configuration implementation is plain ugly, the
level meter didn't work etc. This is all much better configured using
the gnome-control-center sound panel, which is pretty nice for inputs
and saves its volume on pulse for us to re-use :)
Sjoerd Simons [Thu, 17 Nov 2011 19:10:12 +0000 (19:10 +0000)]
Add mute support to the audio source
Sjoerd Simons [Thu, 17 Nov 2011 18:15:55 +0000 (18:15 +0000)]
Implement Audiocontrol for the output volume
Sjoerd Simons [Thu, 17 Nov 2011 18:15:09 +0000 (18:15 +0000)]
Keep the audio sinks volume property synchronized with the pulse volume
Sjoerd Simons [Thu, 17 Nov 2011 16:34:06 +0000 (16:34 +0000)]
Implement input audio control
Sjoerd Simons [Tue, 15 Nov 2011 16:57:20 +0000 (17:57 +0100)]
Let the audio source control the volume, not a software volume element
There is no point in amplifying the mic level is it's too low or too
high as it either doesn't have enough information or it is clipping.
Instead tell pulsesrc what it should do, so it can adjust the hardware
volume for us.
Also listen to changed done by pulsesrc so we can track volume updates
and feed back the settings properly
Xavier Claessens [Wed, 16 Nov 2011 14:31:29 +0000 (15:31 +0100)]
Use _unref instead of _free _destroy when possible.unref
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Xavier Claessens [Wed, 16 Nov 2011 14:31:19 +0000 (15:31 +0100)]
Add coding style check for g_hash_table_destroy and g_array_free usage
Guillaume Desmottes [Wed, 9 Nov 2011 14:20:23 +0000 (15:20 +0100)]
individual-view: don't display menu if empathy_folks_individual_contains_contact() fails
The individual menu already asserts that's the case. And there is no point
displaying a menu anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Wed, 9 Nov 2011 10:37:38 +0000 (11:37 +0100)]
individual-view: add an option to disable uninteresting filtering
This is needed when being used in a muc.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Thu, 10 Nov 2011 11:03:50 +0000 (12:03 +0100)]
individual-widget: display channels list if available
This will be needed when using this widget in MUC.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Thu, 10 Nov 2011 10:45:48 +0000 (11:45 +0100)]
factor out empathy_contact_info_create_channel_list_label()
Move it to empathy-contactinfo-utils so we'll be able to re-use it in
empathy-individual-widget as well.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Thu, 10 Nov 2011 09:54:04 +0000 (10:54 +0100)]
update_weak_contact: use a greater or equal comparaison
That way we'll pick at least one TpContact if there is only one contact in
the individual and he doesn't have any presence (IRC for example).
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Thura Hlaing [Mon, 14 Nov 2011 21:33:45 +0000 (22:33 +0100)]
[l10n]Added Burmese translation
Guillaume Desmottes [Mon, 14 Nov 2011 11:42:59 +0000 (12:42 +0100)]
fix separator leak
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 11:39:58 +0000 (12:39 +0100)]
don't leak uri returned by g_file_get_uri()
God I hate _get functions returning new memory...
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 11:19:54 +0000 (12:19 +0100)]
fix GDate leaks when getting dates from the model
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 11:12:29 +0000 (12:12 +0100)]
free GDate leaks when inserting them into the model
The model copies the date so we should free it afterward.
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 11:01:55 +0000 (12:01 +0100)]
empathy-logs: prepare the account manager first
The log viewer assumes it's already prepared.
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 10:59:31 +0000 (11:59 +0100)]
empathy-logs: port to TP coding style
https://bugzilla.gnome.org/show_bug.cgi?id=663873
Guillaume Desmottes [Mon, 14 Nov 2011 14:35:51 +0000 (15:35 +0100)]
coding style fixes
Guillaume Desmottes [Tue, 8 Nov 2011 15:09:44 +0000 (16:09 +0100)]
main-window: use the EmpathyIndividual flavor of some types
We switched to EmpathyIndividualView a while ago...
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Tue, 8 Nov 2011 15:08:59 +0000 (16:08 +0100)]
empathy_individual_store_remove_individual: use EMPATHY_INDIVIDUAL_STORE_COL_NAME
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Wed, 9 Nov 2011 10:15:56 +0000 (11:15 +0100)]
individual-view: remove explicit boolean comparaisons
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Fri, 4 Nov 2011 09:55:43 +0000 (10:55 +0100)]
individual-store: use self->priv pattern
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Thu, 10 Nov 2011 10:59:42 +0000 (11:59 +0100)]
individual-widget: factor out add_row()
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Guillaume Desmottes [Thu, 10 Nov 2011 09:02:31 +0000 (10:02 +0100)]
details_update_show: skip empty field
https://bugzilla.gnome.org/show_bug.cgi?id=663763
Cheng-Chia Tseng [Sat, 12 Nov 2011 11:10:31 +0000 (19:10 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Mattias Põldaru [Sat, 12 Nov 2011 10:55:55 +0000 (12:55 +0200)]
[l10n] Updated Estonian translation
Sjoerd Simons [Wed, 9 Nov 2011 19:25:17 +0000 (19:25 +0000)]
Don't turn on echo cancellation on the sink if it's for raw conferences
https://bugzilla.gnome.org/show_bug.cgi?id=663842
Sjoerd Simons [Wed, 9 Nov 2011 19:00:10 +0000 (19:00 +0000)]
Don't turn on echo cancellation on the source if it's for raw conferences
https://bugzilla.gnome.org/show_bug.cgi?id=663842
Sjoerd Simons [Wed, 9 Nov 2011 16:27:51 +0000 (16:27 +0000)]
Call: Signal content-{added/removed} instead of sink-{added/removed}
Tp-Farstream signals contents, not sinks (like tp-farsight did). So lets
mirror that, which allows us to make better decisions about what kind of
contents we are given
https://bugzilla.gnome.org/show_bug.cgi?id=663842
Guillaume Desmottes [Thu, 10 Nov 2011 09:23:08 +0000 (10:23 +0100)]
stop using gtk_widget_get_pointer()
It has been deprecated. I asked on #gtk+ and that seems to be the right way to
do this. See
http://git.gnome.org/browse/gtk+/commit/?id=
2783158f8d9ca69e5a8fc4a903bfbcc3871a1b02
All these APIs are available since GTK+ 3.0 so we're good.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
Guillaume Desmottes [Thu, 10 Nov 2011 09:23:08 +0000 (10:23 +0100)]
stop using gdk_window_get_pointer()
It has been deprecated. gdk_window_get_device_position() has been added in
GTK+ 3.0 so we're fine.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
Guillaume Desmottes [Mon, 7 Nov 2011 14:44:59 +0000 (15:44 +0100)]
doesn't allow to send socket files
https://bugzilla.gnome.org/show_bug.cgi?id=663563
Arun Raghavan [Mon, 31 Oct 2011 13:12:56 +0000 (18:42 +0530)]
audio-src: Add a caps filter to select appropriate input format
Instead of relying on the default caps that the pipeline selects (which
will usually end up being float32 stereo at 44.1kHz), this sets a caps
filter to select the format we want from pulsesrc -- s16ne mono at 32kHz.
The point of this is to do resampling/conversion as early in the
pipeline as possible, decreasing the amount of data that needs to be
carried around and thus improving performance a bit.
Guillaume Desmottes [Wed, 9 Nov 2011 09:01:50 +0000 (10:01 +0100)]
empathy_contact_block_menu_item_new: remove unused EmpathyContactManager
Danielle Madeley [Wed, 9 Nov 2011 01:19:07 +0000 (12:19 +1100)]
Merge branch 'status-icon-663567'
Guillaume Desmottes [Thu, 3 Nov 2011 14:07:17 +0000 (15:07 +0100)]
contact-list-view: use empathy_contact_remove_from_contact_list()
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 13:08:29 +0000 (14:08 +0100)]
notifications-approver: stop using EmpathyContactManager
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 13:08:29 +0000 (14:08 +0100)]
contact-dialog: stop using EmpathyContactManager
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 13:54:43 +0000 (14:54 +0100)]
add empathy_contact_remove_from_contact_list()
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 13:08:29 +0000 (14:08 +0100)]
contact-search-dialog: stop using EmpathyContactManager
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 13:08:01 +0000 (14:08 +0100)]
add empathy_contact_add_to_contact_list()
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Thu, 3 Nov 2011 14:00:57 +0000 (15:00 +0100)]
client-factory: prepare TP_CONNECTION_FEATURE_CONTACT_LIST_PROPERTIES
https://bugzilla.gnome.org/show_bug.cgi?id=663327
Guillaume Desmottes [Wed, 2 Nov 2011 09:49:01 +0000 (10:49 +0100)]
remove old blocking API
https://bugzilla.gnome.org/show_bug.cgi?id=661805
Guillaume Desmottes [Wed, 2 Nov 2011 10:18:50 +0000 (11:18 +0100)]
individual dialog: use tp-glib blocking API
https://bugzilla.gnome.org/show_bug.cgi?id=661805
Guillaume Desmottes [Wed, 2 Nov 2011 09:59:06 +0000 (10:59 +0100)]
individual-manager: use tp-glib blocking API
https://bugzilla.gnome.org/show_bug.cgi?id=661805
Guillaume Desmottes [Wed, 2 Nov 2011 09:59:06 +0000 (10:59 +0100)]
contact-dialogs: use tp-glib blocking API
https://bugzilla.gnome.org/show_bug.cgi?id=661805
Guillaume Desmottes [Wed, 2 Nov 2011 09:43:19 +0000 (10:43 +0100)]
contact-menu: use tp-glib blocking API
https://bugzilla.gnome.org/show_bug.cgi?id=661805
Guillaume Desmottes [Wed, 2 Nov 2011 10:41:49 +0000 (11:41 +0100)]
Revert "Revert "contact-blocking-dialog: use tp-glib high level blocking API""
This reverts commit
40dc4074eeecb15c82d9eacb3fcd54cff7162440.
We can now depends on it.
Guillaume Desmottes [Tue, 8 Nov 2011 12:22:55 +0000 (13:22 +0100)]
depends on tp-glib 0.17.0
We need it for high level blocking API.
Guillaume Desmottes [Fri, 4 Nov 2011 12:42:53 +0000 (13:42 +0100)]
contact-chooser: fix TpfPersona leak
We weren't using the persona we just created for some reason.
Danielle Madeley [Tue, 8 Nov 2011 00:17:56 +0000 (11:17 +1100)]
Remove dead files codec-preferences and element-preferences
These are now handled for us by Farsight. Hooray for Farsight.
Danielle Madeley [Mon, 7 Nov 2011 22:49:41 +0000 (09:49 +1100)]
accounts-dialog: fix box packing issue in infobar
Expanding the status causes the icon to be placed on the far left of the box.
This regression caused by my work in
1cd6e8253a3be284b8578fd9ea37016d0197d61b.
Need an additional hbox and to expand that.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=663567
Sjoerd Simons [Mon, 7 Nov 2011 11:37:12 +0000 (11:37 +0000)]
call: Fix GstCaps leak
Sjoerd Simons [Mon, 7 Nov 2011 11:04:14 +0000 (11:04 +0000)]
Call: Cope with not having the Channel direclty after startin a call
Sjoerd Simons [Fri, 4 Nov 2011 18:58:50 +0000 (18:58 +0000)]
Use videorate max-rate property
Using the max-rate property is simpler and less racy, so do that
instead. Does require (currently unreleased) gst-plugins-base 0.10.36
Sjoerd Simons [Fri, 4 Nov 2011 18:46:24 +0000 (18:46 +0000)]
When reset the source remove and re-insert it
Setting an element to NULL resets various internal values (the clock,
the base time etc). To make sure everything is reset as expected simply
yank it from the bin and re-insert it (which will reset the values)
Sjoerd Simons [Fri, 4 Nov 2011 18:45:22 +0000 (18:45 +0000)]
Drop EOS from the src
Sjoerd Simons [Fri, 4 Nov 2011 18:44:35 +0000 (18:44 +0000)]
Don't go asynchronously to paused
Nicolas Dufresne [Mon, 11 Jul 2011 23:44:42 +0000 (19:44 -0400)]
Ignore dynamic framerate if videomaxrate is missing
Nicolas Dufresne [Mon, 11 Jul 2011 23:45:46 +0000 (19:45 -0400)]
Use framerate range instead of fix range
Using framerate range reduce the chance that changing the framerate breaks
the pipline. We also always set an initial range to support src like
videotestsrc that does not allow changing framerate dynamically and would
default to a "as fast as possible" mode.
Nicolas Dufresne [Mon, 11 Jul 2011 21:01:45 +0000 (17:01 -0400)]
Reset clock after changing video resolution
This workaround issue with videotestsrc when the test src does not have a
a clock after going to NULL state while changing resolution.
Nicolas Dufresne [Thu, 7 Jul 2011 20:19:17 +0000 (16:19 -0400)]
Change element state sink to source
Nicolas Dufresne [Thu, 7 Jul 2011 18:27:30 +0000 (14:27 -0400)]
Don't call GTK method from streaming thread
Also update from deprecated gst_x_overlay_set_xwindow_id() to
gst_x_overlay_set_window_handle().
Nicolas Dufresne [Wed, 6 Jul 2011 22:18:58 +0000 (18:18 -0400)]
Hook resolution change support