dispatch-operation: fix a race by waiting that TpCall is ready
The call handler constructor rely on the TpCall to be ready (to fetch the
EmpathyContact associated with the call). If things are going fast (by
skipping the approving of the call and handling it right away for example) it
may no be ready yet.
empathy_call_window_set_send_video: only disable preview if we need to
There is no point to stop the camera if we're about to restart it right after
because "preview only" is enabled.
Furthermore that causes weird races making the video jumps out of the window
(#62076).
Rob Bradford [Thu, 3 Jun 2010 13:24:21 +0000 (14:24 +0100)]
accounts-dialog: avoid leaking the account status message
Originally this function mixed const and allocated strings using the same
variable, resulting in leaks. This change refactors the code slightly to
prevent such leaks.
Rob Bradford [Wed, 2 Jun 2010 11:47:34 +0000 (12:47 +0100)]
accounts-dialog: Ensure correct connectivity information
Move the creation of the EmpathyConnectivity object to the dialog
construction so that there is time for the asynchronous calls that
the EmpathyConnectivity makes (in ConnMan mode) to return.
Without this change the error is always reported as network connection failure
rather than the real error when built with ConnMan.
Don't wait longer than 5 seconds when trying to join chatrooms
If the accounts takes ages to connect or was disabled, it would be weird to
automatically join the room a long time after the user asked to join
favorite rooms.
Jonas Bonn [Fri, 5 Mar 2010 15:52:08 +0000 (16:52 +0100)]
Make chatroom manager retain room's "always_urgent" state
This patch adds the always_urgent property to the list of chatroom
properties that are saved by the chatroom manager for the favorite
chatrooms. This allows Empathy to bring favorite chatrooms back
up with the same notification properties they had the last time they
were used.
This seems reasonable as a room marked as "Notify Always" will most likely
be of such a character that this would be a reasonable setting every time
the room is joined.
Jonas Bonn [Fri, 5 Mar 2010 11:55:25 +0000 (12:55 +0100)]
Add option to make chatroom "always urgent" (#611894)
Often a user wants to be immediately notified of posts to a chatroom even when
the post does not address them directly by name. This patch adds a room
option to make all posts to the room "urgent", meaning that the system-specific
urgency action should be taken -- notification, window urgency hint, etc.
Two specific use cases for when one may want this:
i) Low-traffic rooms (so that one does not have to go check the room all the
time)
ii) Error-logging room (room to which errors from some other system(s) are
logged)
The "always urgent" option is off by default when joining a room.
Xavier Claessens [Thu, 20 May 2010 14:12:57 +0000 (16:12 +0200)]
Make sure to not infinite loop when scaling avatar.
1) Add a limit of 10 retries, to be sure to never do more in the worst case.
2) Only keep converted data that respect the requirements, make sure to not
accept bigger data than maximum_bytes, even if it is close to the limit.
3) Stop the loop if the new factor does not change the image resolution. That
means we already found the optimal size.
assistant: call empathy_import_widget_add_selected_accounts in impl_signal_apply as well
If the user already has a salut account configured, the import page is the
last one of the assistant. So impl_signal_apply() is called instead of
impl_signal_prepare(). (#617971)
Robert McQueen [Sat, 15 May 2010 12:54:18 +0000 (13:54 +0100)]
use user-extended-away status icon in favour of user-idle
The freedesktop.org icon spec defines that the icon for the extended away
status is called user-idle. However, some icon theme authors interpret this
name as meaning mere idleness rather than the intended extended away semantic
of away *and* idle, creating visual confusion (extended-away contacts appearing
less away than contacts who are merely away). Some themes contain a
non-standard user-extended-away icon with the correct semantic, so this patch
makes Empathy use it in preference to user-idle if available. (Incidentally, at
the moment Telepathy itself never actually shows remote contacts as idle.)