]> git.0d.be Git - empathy.git/blobdiff - src/empathy-status-icon.c
Make use of GtkUIManager in EmpathyStatusIcon
[empathy.git] / src / empathy-status-icon.c
index 197b22401f48e71b32a7f976db8d9a84ff3ba31e..1824be5e6f55371986d89fcae7504de61f9d1189 100644 (file)
@@ -24,7 +24,6 @@
 #include <string.h>
 
 #include <gtk/gtk.h>
-#include <glade/glade.h>
 #include <gdk/gdkkeysyms.h>
 
 #include <libnotify/notification.h>
@@ -63,10 +62,11 @@ typedef struct {
        NotifyNotification  *notification;
 
        GtkWindow           *window;
+       GtkUIManager        *ui_manager;
        GtkWidget           *popup_menu;
-       GtkWidget           *show_window_item;
-       GtkWidget           *message_item;
-       GtkWidget           *status_item;
+       GtkAction           *show_window_item;
+       GtkAction           *new_message_item;
+       GtkAction           *status_item;
 } EmpathyStatusIconPriv;
 
 G_DEFINE_TYPE (EmpathyStatusIcon, empathy_status_icon, G_TYPE_OBJECT);
@@ -84,7 +84,7 @@ status_icon_notification_closed_cb (NotifyNotification *notification,
                                    EmpathyStatusIcon  *icon)
 {
        EmpathyStatusIconPriv *priv = GET_PRIV (icon);
-       int reason = 1;
+       EmpathyNotificationClosedReason reason = 0;
 
 #ifdef notify_notification_get_closed_reason
        reason = notify_notification_get_closed_reason (notification);
@@ -101,7 +101,11 @@ status_icon_notification_closed_cb (NotifyNotification *notification,
        /* the notification has been closed by the user, see the
         * DesktopNotification spec.
         */
-       if (reason == 2) {
+       if (reason == EMPATHY_NOTIFICATION_CLOSED_DISMISSED) {
+               /* use an idle here, as this callback is called from a
+                * DBus signal handler inside libnotify, and we might call
+                * a *_run_* method when activating the event.
+                */
                g_idle_add ((GSourceFunc) activate_event, priv->event);
        } else {
                /* inhibit other updates for this event */
@@ -109,24 +113,6 @@ status_icon_notification_closed_cb (NotifyNotification *notification,
        }
 }
 
-static GdkPixbuf *
-get_pixbuf_for_event (EmpathyEvent *event)
-{
-       GdkPixbuf *pixbuf = NULL;
-
-       if (event->contact != NULL) {
-               pixbuf = empathy_pixbuf_avatar_from_contact_scaled (event->contact,
-                                                                   48, 48);
-       }
-
-       if (!pixbuf) {
-               pixbuf = empathy_pixbuf_from_icon_name_sized
-                                       (event->icon_name, 48);
-       }
-
-       return pixbuf;
-}
-
 static void
 notification_close_helper (EmpathyStatusIconPriv *priv)
 {
@@ -150,7 +136,8 @@ status_icon_update_notification (EmpathyStatusIcon *icon)
        }
 
        if (priv->event) {
-               pixbuf = get_pixbuf_for_event (priv->event);
+               pixbuf = empathy_misc_get_pixbuf_for_notification (priv->event->contact,
+                                                                  priv->event->icon_name);
 
                if (priv->notification) {
                        notify_notification_update (priv->notification,
@@ -183,20 +170,19 @@ status_icon_update_tooltip (EmpathyStatusIcon *icon)
        gchar                 *tooltip = NULL;
 
        if (priv->event) {
-               tooltip = g_strdup_printf ("%s\n%s",
-                                          priv->event->header,
-                                          priv->event->message);
-       }
-
-       if (!tooltip) {
+               if (priv->event->message != NULL)
+                               tooltip = g_strdup_printf ("<i>%s</i>\n%s",
+                                                          priv->event->header,
+                                                          priv->event->message);
+               else
+                               tooltip = g_strdup_printf ("<i>%s</i>",
+                                                          priv->event->header);
+               gtk_status_icon_set_tooltip_markup (priv->icon, tooltip);
+       } else {
                tooltip = g_strdup (empathy_idle_get_status (priv->idle));
+               gtk_status_icon_set_tooltip_text (priv->icon, tooltip);
        }
 
-       /* FIXME: when we will depend on GTK+ 2.16.0, we should use
-        * gtk_status_icon_set_tooltip_markup () and make the header italic.
-        */
-       gtk_status_icon_set_tooltip (priv->icon, tooltip);
-
        g_free (tooltip);
 }
 
@@ -408,24 +394,24 @@ status_icon_activate_cb (GtkStatusIcon     *status_icon,
 }
 
 static void
-status_icon_show_hide_window_cb (GtkWidget         *widget,
+status_icon_show_hide_window_cb (GtkToggleAction   *action,
                                 EmpathyStatusIcon *icon)
 {
        gboolean visible;
 
-       visible = gtk_check_menu_item_get_active (GTK_CHECK_MENU_ITEM (widget));
+       visible = gtk_toggle_action_get_active (action);
        status_icon_set_visibility (icon, visible, TRUE);
 }
 
 static void
-status_icon_new_message_cb (GtkWidget         *widget,
+status_icon_new_message_cb (GtkAction         *action,
                            EmpathyStatusIcon *icon)
 {
        empathy_new_message_dialog_show (NULL);
 }
 
 static void
-status_icon_quit_cb (GtkWidget         *window,
+status_icon_quit_cb (GtkAction         *action,
                     EmpathyStatusIcon *icon)
 {
        gtk_main_quit ();
@@ -438,6 +424,7 @@ status_icon_popup_menu_cb (GtkStatusIcon     *status_icon,
                           EmpathyStatusIcon *icon)
 {
        EmpathyStatusIconPriv *priv = GET_PRIV (icon);
+       GtkWidget             *menu_item;
        GtkWidget             *submenu;
        gboolean               show;
 
@@ -446,15 +433,15 @@ status_icon_popup_menu_cb (GtkStatusIcon     *status_icon,
        g_signal_handlers_block_by_func (priv->show_window_item,
                                         status_icon_show_hide_window_cb,
                                         icon);
-       gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (priv->show_window_item),
-                                       show);
+       gtk_toggle_action_set_active (GTK_TOGGLE_ACTION (priv->show_window_item),
+                                     show);
        g_signal_handlers_unblock_by_func (priv->show_window_item,
                                           status_icon_show_hide_window_cb,
                                           icon);
 
+       menu_item = gtk_ui_manager_get_widget (priv->ui_manager, "/menu/status");
        submenu = empathy_presence_chooser_create_menu ();
-       gtk_menu_item_set_submenu (GTK_MENU_ITEM (priv->status_item),
-                                  submenu);
+       gtk_menu_item_set_submenu (GTK_MENU_ITEM (menu_item), submenu);
 
        gtk_menu_popup (GTK_MENU (priv->popup_menu),
                        NULL, NULL,
@@ -468,28 +455,27 @@ static void
 status_icon_create_menu (EmpathyStatusIcon *icon)
 {
        EmpathyStatusIconPriv *priv = GET_PRIV (icon);
-       GladeXML              *glade;
+       GtkBuilder            *gui;
        gchar                 *filename;
 
-       filename = empathy_file_lookup ("empathy-status-icon.glade", "src");
-       glade = empathy_glade_get_file (filename,
-                                      "tray_menu",
-                                      NULL,
-                                      "tray_menu", &priv->popup_menu,
-                                      "tray_show_list", &priv->show_window_item,
-                                      "tray_new_message", &priv->message_item,
-                                      "tray_status", &priv->status_item,
+       filename = empathy_file_lookup ("empathy-status-icon.ui", "src");
+       gui = empathy_builder_get_file (filename,
+                                       "ui_manager", &priv->ui_manager,
+                                       "menu", &priv->popup_menu,
+                                       "show_list", &priv->show_window_item,
+                                       "new_message", &priv->new_message_item,
+                                       "status", &priv->status_item,
                                       NULL);
        g_free (filename);
 
-       empathy_glade_connect (glade,
-                             icon,
-                             "tray_show_list", "toggled", status_icon_show_hide_window_cb,
-                             "tray_new_message", "activate", status_icon_new_message_cb,
-                             "tray_quit", "activate", status_icon_quit_cb,
+       empathy_builder_connect (gui, icon,
+                             "show_list", "toggled", status_icon_show_hide_window_cb,
+                             "new_message", "activate", status_icon_new_message_cb,
+                             "quit", "activate", status_icon_quit_cb,
                              NULL);
 
-       g_object_unref (glade);
+       g_object_ref (priv->ui_manager);
+       g_object_unref (gui);
 }
 
 static void
@@ -506,7 +492,7 @@ status_icon_connection_changed_cb (EmpathyAccountManager *manager,
        /* Check for a connected account */
        connected_accounts = empathy_account_manager_get_connected_accounts (manager);
 
-       gtk_widget_set_sensitive (priv->message_item, connected_accounts > 0);
+       gtk_action_set_sensitive (priv->new_message_item, connected_accounts > 0);
 }
 
 static void
@@ -532,6 +518,7 @@ status_icon_finalize (GObject *object)
        g_object_unref (priv->idle);
        g_object_unref (priv->account_manager);
        g_object_unref (priv->event_manager);
+       g_object_unref (priv->ui_manager);
 }
 
 static void
@@ -603,7 +590,7 @@ empathy_status_icon_new (GtkWindow *window, gboolean hide_contact_list)
 
        priv->window = g_object_ref (window);
 
-       g_signal_connect (priv->window, "key-press-event",
+       g_signal_connect_after (priv->window, "key-press-event",
                          G_CALLBACK (status_icon_key_press_event_cb),
                          icon);