]> git.0d.be Git - empathy.git/blobdiff - libempathy/empathy-tp-contact-list.c
local-xmpp-assistant-widget: increase row-spacing
[empathy.git] / libempathy / empathy-tp-contact-list.c
index f2197949570831f2d43c6207256bd51946f8cb50..f116d15d35ae2c25033a1a706f84729ae6bd5f63 100644 (file)
@@ -31,6 +31,8 @@
 #include <telepathy-glib/dbus.h>
 #include <telepathy-glib/interfaces.h>
 
+#include <extensions/extensions.h>
+
 #include "empathy-tp-contact-list.h"
 #include "empathy-tp-contact-factory.h"
 #include "empathy-contact-list.h"
@@ -41,7 +43,6 @@
 
 #define GET_PRIV(obj) EMPATHY_GET_PRIV (obj, EmpathyTpContactList)
 typedef struct {
-       EmpathyTpContactFactory *factory;
        TpConnection   *connection;
 
        TpChannel      *publish;
@@ -68,8 +69,6 @@ typedef struct {
        GHashTable     *groups;
        /* group name: owned (gchar *) => owned GArray of TpHandle */
        GHashTable     *add_to_group;
-
-       EmpathyContactListFlags flags;
 } EmpathyTpContactListPriv;
 
 typedef enum {
@@ -243,6 +242,7 @@ tp_contact_list_group_ready_cb (TpChannel *channel,
                g_object_unref (old_group);
        }
 
+       /* Pass the reference on the TpChannel to priv->groups */
        g_hash_table_insert (priv->groups, (gpointer) group_name, channel);
        DEBUG ("Group %s added", group_name);
 
@@ -271,7 +271,7 @@ tp_contact_list_group_ready_cb (TpChannel *channel,
        g_assert (members != NULL);
        arr = tp_intset_to_array (members);
        contacts_added_to_group (list, channel, arr);
-       g_array_free (arr, TRUE);
+       g_array_unref (arr);
 }
 
 static void
@@ -352,7 +352,7 @@ tp_contact_list_group_add (EmpathyTpContactList *list,
        if (channel) {
                tp_cli_channel_interface_group_call_add_members (channel, -1,
                        handles, NULL, NULL, NULL, NULL, NULL);
-               g_array_free (handles, TRUE);
+               g_array_unref (handles);
                return;
        }
 
@@ -372,7 +372,7 @@ tp_contact_list_group_add (EmpathyTpContactList *list,
 }
 
 static void
-got_added_members_cb (EmpathyTpContactFactory *factory,
+got_added_members_cb (TpConnection            *connection,
                      guint                    n_contacts,
                      EmpathyContact * const * contacts,
                      guint                    n_failed,
@@ -427,16 +427,16 @@ add_to_members (EmpathyTpContactList *list,
        }
 
        if (request->len > 0) {
-                       empathy_tp_contact_factory_get_from_handles (priv->factory,
+                       empathy_tp_contact_factory_get_from_handles (priv->connection,
                                request->len, (TpHandle *) request->data,
                                got_added_members_cb, NULL, NULL, G_OBJECT (list));
        }
 
-       g_array_free (request, TRUE);
+       g_array_unref (request);
 }
 
 static void
-tp_contact_list_got_local_pending_cb (EmpathyTpContactFactory *factory,
+tp_contact_list_got_local_pending_cb (TpConnection            *connection,
                                      guint                    n_contacts,
                                      EmpathyContact * const * contacts,
                                      guint                    n_failed,
@@ -458,12 +458,18 @@ tp_contact_list_got_local_pending_cb (EmpathyTpContactFactory *factory,
                TpHandle handle;
                const gchar *message;
                TpChannelGroupChangeReason reason;
+               const TpIntSet *members, *remote_pending;
 
                handle = empathy_contact_get_handle (contact);
-               if (g_hash_table_lookup (priv->members, GUINT_TO_POINTER (handle))) {
+               members = tp_channel_group_get_members (priv->subscribe);
+               remote_pending = tp_channel_group_get_remote_pending (priv->subscribe);
+
+               if (tp_intset_is_member (members, handle) ||
+                   tp_intset_is_member (remote_pending, handle)) {
                        GArray handles = {(gchar *) &handle, 1};
 
-                       /* This contact is already member, auto accept. */
+                       /* This contact is already subscribed, or user requested
+                        * to subscribe, auto accept. */
                        tp_cli_channel_interface_group_call_add_members (priv->publish,
                                -1, &handles, NULL, NULL, NULL, NULL, NULL);
                }
@@ -562,71 +568,13 @@ tp_contact_list_publish_group_members_changed_cb (TpChannel     *channel,
        /* Those contacts want our presence, auto accept those that are already
         * member, otherwise add in pendings. */
        if (local_pending->len > 0) {
-               empathy_tp_contact_factory_get_from_handles (priv->factory,
+               empathy_tp_contact_factory_get_from_handles (priv->connection,
                        local_pending->len, (TpHandle *) local_pending->data,
                        tp_contact_list_got_local_pending_cb, NULL, NULL,
                        G_OBJECT (list));
        }
 }
 
-static void
-tp_contact_list_get_alias_flags_cb (TpConnection *connection,
-                                   guint         flags,
-                                   const GError *error,
-                                   gpointer      user_data,
-                                   GObject      *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-
-       if (error) {
-               DEBUG ("Error: %s", error->message);
-               return;
-       }
-
-       if (flags & TP_CONNECTION_ALIAS_FLAG_USER_SET) {
-               priv->flags |= EMPATHY_CONTACT_LIST_CAN_ALIAS;
-       }
-}
-
-static void
-tp_contact_list_get_requestablechannelclasses_cb (TpProxy      *connection,
-                                                 const GValue *value,
-                                                 const GError *error,
-                                                 gpointer      user_data,
-                                                 GObject      *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-       GPtrArray *classes;
-       guint i;
-
-       if (error) {
-               DEBUG ("Error: %s", error->message);
-               return;
-       }
-
-       classes = g_value_get_boxed (value);
-       for (i = 0; i < classes->len; i++) {
-               GValueArray *class = g_ptr_array_index (classes, i);
-               GHashTable *props;
-               const char *channel_type;
-               guint handle_type;
-
-               props = g_value_get_boxed (g_value_array_get_nth (class, 0));
-
-               channel_type = tp_asv_get_string (props,
-                               TP_IFACE_CHANNEL ".ChannelType");
-               handle_type = tp_asv_get_uint32 (props,
-                               TP_IFACE_CHANNEL ".TargetHandleType", NULL);
-
-               if (!tp_strdiff (channel_type, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST) &&
-                   handle_type == TP_HANDLE_TYPE_GROUP) {
-                       DEBUG ("Got channel class for a contact group");
-                       priv->flags |= EMPATHY_CONTACT_LIST_CAN_GROUP;
-                       break;
-               }
-       }
-}
-
 static void
 tp_contact_list_subscribe_group_members_changed_cb (TpChannel     *channel,
                                                    gchar         *message,
@@ -655,6 +603,9 @@ tp_contact_list_subscribe_group_members_changed_cb (TpChannel     *channel,
        add_to_members (list, remote_pending);
 
        /* Implicitly accept pending request of contacts which are now members. */
+       if (priv->publish == NULL)
+               return;
+
        accept = g_array_new (FALSE, FALSE, sizeof (TpHandle));
        for (i = 0; i < added->len; i++) {
                TpHandle handle = g_array_index (added, TpHandle, i);
@@ -673,7 +624,7 @@ tp_contact_list_subscribe_group_members_changed_cb (TpChannel     *channel,
        tp_cli_channel_interface_group_call_add_members (priv->publish,
                -1, accept, NULL, NULL, NULL, NULL, NULL);
 
-       g_array_free (accept, TRUE);
+       g_array_unref (accept);
 }
 
 static void
@@ -723,20 +674,16 @@ tp_contact_list_finalize (GObject *object)
                g_object_unref (priv->connection);
        }
 
-       if (priv->factory) {
-               g_object_unref (priv->factory);
-       }
-
        g_hash_table_iter_init (&iter, priv->groups);
        while (g_hash_table_iter_next (&iter, NULL, &channel)) {
                g_signal_handlers_disconnect_by_func (channel,
                        tp_contact_list_group_invalidated_cb, list);
        }
 
-       g_hash_table_destroy (priv->groups);
-       g_hash_table_destroy (priv->members);
-       g_hash_table_destroy (priv->pendings);
-       g_hash_table_destroy (priv->add_to_group);
+       g_hash_table_unref (priv->groups);
+       g_hash_table_unref (priv->members);
+       g_hash_table_unref (priv->pendings);
+       g_hash_table_unref (priv->add_to_group);
 
        G_OBJECT_CLASS (empathy_tp_contact_list_parent_class)->finalize (object);
 }
@@ -882,8 +829,8 @@ conn_ready_cb (TpConnection *connection,
                NULL, NULL, G_OBJECT (list));
 
        request = tp_asv_new (
-               TP_IFACE_CHANNEL ".ChannelType", G_TYPE_STRING, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST,
-               TP_IFACE_CHANNEL ".TargetHandleType", G_TYPE_UINT, TP_HANDLE_TYPE_LIST,
+               TP_PROP_CHANNEL_CHANNEL_TYPE, G_TYPE_STRING, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST,
+               TP_PROP_CHANNEL_TARGET_HANDLE_TYPE, G_TYPE_UINT, TP_HANDLE_TYPE_LIST,
                NULL);
 
        /* Watch the NewChannels signal so if ensuring list channels fails (for
@@ -893,21 +840,22 @@ conn_ready_cb (TpConnection *connection,
                priv->connection, new_channels_cb, NULL, NULL, G_OBJECT (list), NULL);
 
        /* Request the 'stored' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "stored");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "stored");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
                G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        /* Request the 'publish' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "publish");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "publish");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
                G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        /* Request the 'subscribe' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "subscribe");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "subscribe");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
                G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        g_hash_table_unref (request);
+
 out:
        g_object_unref (list);
 }
@@ -917,34 +865,6 @@ tp_contact_list_constructed (GObject *list)
 {
        EmpathyTpContactListPriv *priv = GET_PRIV (list);
 
-       priv->factory = empathy_tp_contact_factory_dup_singleton (priv->connection);
-
-       /* call GetAliasFlags */
-       if (tp_proxy_has_interface_by_id (priv->connection,
-                               TP_IFACE_QUARK_CONNECTION_INTERFACE_ALIASING)) {
-               tp_cli_connection_interface_aliasing_call_get_alias_flags (
-                               priv->connection,
-                               -1,
-                               tp_contact_list_get_alias_flags_cb,
-                               NULL, NULL,
-                               G_OBJECT (list));
-       }
-
-       /* lookup RequestableChannelClasses */
-       if (tp_proxy_has_interface_by_id (priv->connection,
-                               TP_IFACE_QUARK_CONNECTION_INTERFACE_REQUESTS)) {
-               tp_cli_dbus_properties_call_get (priv->connection,
-                               -1,
-                               TP_IFACE_CONNECTION_INTERFACE_REQUESTS,
-                               "RequestableChannelClasses",
-                               tp_contact_list_get_requestablechannelclasses_cb,
-                               NULL, NULL,
-                               G_OBJECT (list));
-       } else {
-               /* we just don't know... better mark the flag just in case */
-               priv->flags |= EMPATHY_CONTACT_LIST_CAN_GROUP;
-       }
-
        tp_connection_call_when_ready (priv->connection, conn_ready_cb,
                g_object_ref (list));
 }
@@ -1010,7 +930,7 @@ empathy_tp_contact_list_class_init (EmpathyTpContactListClass *klass)
 static void
 tp_contact_list_array_free (gpointer handles)
 {
-       g_array_free (handles, TRUE);
+       g_array_unref (handles);
 }
 
 static void
@@ -1073,10 +993,12 @@ tp_contact_list_add (EmpathyContactList *list,
        GArray handles = {(gchar *) &handle, 1};
 
        handle = empathy_contact_get_handle (contact);
+
        if (priv->subscribe) {
                tp_cli_channel_interface_group_call_add_members (priv->subscribe,
                        -1, &handles, message, NULL, NULL, NULL, NULL);
        }
+
        if (priv->publish) {
                TpChannelGroupFlags flags = tp_channel_group_get_flags (priv->subscribe);
                if (flags & TP_CHANNEL_GROUP_FLAG_CAN_ADD ||
@@ -1085,6 +1007,15 @@ tp_contact_list_add (EmpathyContactList *list,
                                -1, &handles, message, NULL, NULL, NULL, NULL);
                }
        }
+
+       /* We want to unblock the contact */
+       if (tp_proxy_has_interface_by_id (priv->connection,
+               TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_BLOCKING)) {
+               TpContact *tp_contact = empathy_contact_get_tp_contact (contact);
+
+               if (tp_contact != NULL)
+                       tp_contact_unblock_async (tp_contact, NULL, NULL);
+       }
 }
 
 static void
@@ -1137,20 +1068,6 @@ tp_contact_list_get_pendings (EmpathyContactList *list)
        return ret;
 }
 
-static GList *
-tp_contact_list_get_all_groups (EmpathyContactList *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-       GList                    *ret, *l;
-
-       ret = g_hash_table_get_keys (priv->groups);
-       for (l = ret; l; l = l->next) {
-               l->data = g_strdup (l->data);
-       }
-
-       return ret;
-}
-
 static GList *
 tp_contact_list_get_groups (EmpathyContactList *list,
                            EmpathyContact     *contact)
@@ -1264,35 +1181,7 @@ tp_contact_list_remove_group (EmpathyContactList *list,
        tp_cli_channel_interface_group_call_remove_members (channel, -1,
                handles, NULL, NULL, NULL, NULL, NULL);
        tp_cli_channel_call_close (channel, -1, NULL, NULL, NULL, NULL);
-       g_array_free (handles, TRUE);
-}
-
-static EmpathyContactListFlags
-tp_contact_list_get_flags (EmpathyContactList *list)
-{
-       EmpathyTpContactListPriv *priv;
-       EmpathyContactListFlags flags;
-
-       g_return_val_if_fail (EMPATHY_IS_TP_CONTACT_LIST (list), FALSE);
-
-       priv = GET_PRIV (list);
-       flags = priv->flags;
-
-       if (priv->subscribe != NULL) {
-               TpChannelGroupFlags group_flags;
-
-               group_flags = tp_channel_group_get_flags (priv->subscribe);
-
-               if (group_flags & TP_CHANNEL_GROUP_FLAG_CAN_ADD) {
-                       flags |= EMPATHY_CONTACT_LIST_CAN_ADD;
-               }
-
-               if (group_flags & TP_CHANNEL_GROUP_FLAG_CAN_REMOVE) {
-                       flags |= EMPATHY_CONTACT_LIST_CAN_REMOVE;
-               }
-       }
-
-       return flags;
+       g_array_unref (handles);
 }
 
 static void
@@ -1302,13 +1191,11 @@ tp_contact_list_iface_init (EmpathyContactListIface *iface)
        iface->remove            = tp_contact_list_remove;
        iface->get_members       = tp_contact_list_get_members;
        iface->get_pendings      = tp_contact_list_get_pendings;
-       iface->get_all_groups    = tp_contact_list_get_all_groups;
        iface->get_groups        = tp_contact_list_get_groups;
        iface->add_to_group      = tp_contact_list_add_to_group;
        iface->remove_from_group = tp_contact_list_remove_from_group;
        iface->rename_group      = tp_contact_list_rename_group;
        iface->remove_group      = tp_contact_list_remove_group;
-       iface->get_flags         = tp_contact_list_get_flags;
 }
 
 void
@@ -1337,4 +1224,3 @@ empathy_tp_contact_list_remove_all (EmpathyTpContactList *list)
        }
        g_hash_table_remove_all (priv->pendings);
 }
-