]> git.0d.be Git - empathy.git/blobdiff - libempathy/empathy-tp-contact-list.c
local-xmpp-assistant-widget: increase row-spacing
[empathy.git] / libempathy / empathy-tp-contact-list.c
index 9288baa4c2c3773f32c09112e82b084cc67f3334..f116d15d35ae2c25033a1a706f84729ae6bd5f63 100644 (file)
@@ -31,6 +31,8 @@
 #include <telepathy-glib/dbus.h>
 #include <telepathy-glib/interfaces.h>
 
+#include <extensions/extensions.h>
+
 #include "empathy-tp-contact-list.h"
 #include "empathy-tp-contact-factory.h"
 #include "empathy-contact-list.h"
 
 #define GET_PRIV(obj) EMPATHY_GET_PRIV (obj, EmpathyTpContactList)
 typedef struct {
-       EmpathyTpContactFactory *factory;
        TpConnection   *connection;
-       const gchar    *protocol_group;
 
        TpChannel      *publish;
        TpChannel      *subscribe;
        TpChannel      *stored;
-       GHashTable     *members; /* handle -> EmpathyContact */
-       GHashTable     *pendings; /* handle -> EmpathyContact */
-       GHashTable     *groups; /* group name -> TpChannel */
-       GHashTable     *add_to_group; /* group name -> GArray of handles */
-
-       EmpathyContactListFlags flags;
-
-       TpProxySignalConnection *new_channels_sig;
+       /* contact handle (TpHandle) => reffed (EmpathyContact *)
+        *
+        * Union of:
+        *  - members of 'subscribe': we receive their presence
+        *  - RP of 'subscribe': we asked to receive their presence
+        *  - members of 'publish': we send them our presence
+        *  - members of 'stored': they are in our roster
+        */
+       GHashTable     *members;
+       /* contact handle (TpHandle) => reffed (EmpathyContact *)
+        *
+        * Contacts which are local-pending in the publish channel but are NOT in
+        * the members hash table: they asked to receive our presence and we don't
+        * receive theirs or asked to.
+        * That's basically the contacts which asked to add us to their contact
+        * list and we didn't answer it. */
+       GHashTable     *pendings;
+       /* group name: borrowed (const gchar *)  => reffed (TpChannel *) */
+       GHashTable     *groups;
+       /* group name: owned (gchar *) => owned GArray of TpHandle */
+       GHashTable     *add_to_group;
 } EmpathyTpContactListPriv;
 
 typedef enum {
@@ -229,6 +242,7 @@ tp_contact_list_group_ready_cb (TpChannel *channel,
                g_object_unref (old_group);
        }
 
+       /* Pass the reference on the TpChannel to priv->groups */
        g_hash_table_insert (priv->groups, (gpointer) group_name, channel);
        DEBUG ("Group %s added", group_name);
 
@@ -257,29 +271,26 @@ tp_contact_list_group_ready_cb (TpChannel *channel,
        g_assert (members != NULL);
        arr = tp_intset_to_array (members);
        contacts_added_to_group (list, channel, arr);
-       g_array_free (arr, TRUE);
+       g_array_unref (arr);
 }
 
 static void
 tp_contact_list_group_add_channel (EmpathyTpContactList *list,
                                   const gchar          *object_path,
-                                  const gchar          *channel_type,
-                                  TpHandleType          handle_type,
-                                  guint                 handle)
+                                  GHashTable           *properties)
 {
        EmpathyTpContactListPriv *priv = GET_PRIV (list);
        TpChannel                *channel;
+       GError *error = NULL;
 
-       /* Only accept server-side contact groups */
-       if (tp_strdiff (channel_type, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST) ||
-           handle_type != TP_HANDLE_TYPE_GROUP) {
+       channel = tp_channel_new_from_properties (priv->connection,
+                                 object_path, properties, &error);
+       if (channel == NULL) {
+               DEBUG ("Failed to create group channel: %s", error->message);
+               g_error_free (error);
                return;
        }
 
-       channel = tp_channel_new (priv->connection,
-                                 object_path, channel_type,
-                                 handle_type, handle, NULL);
-
        /* Give the ref to the callback */
        tp_channel_call_when_ready (channel,
                                    tp_contact_list_group_ready_cb,
@@ -341,7 +352,7 @@ tp_contact_list_group_add (EmpathyTpContactList *list,
        if (channel) {
                tp_cli_channel_interface_group_call_add_members (channel, -1,
                        handles, NULL, NULL, NULL, NULL, NULL);
-               g_array_free (handles, TRUE);
+               g_array_unref (handles);
                return;
        }
 
@@ -361,14 +372,14 @@ tp_contact_list_group_add (EmpathyTpContactList *list,
 }
 
 static void
-tp_contact_list_got_added_members_cb (EmpathyTpContactFactory *factory,
-                                     guint                    n_contacts,
-                                     EmpathyContact * const * contacts,
-                                     guint                    n_failed,
-                                     const TpHandle          *failed,
-                                     const GError            *error,
-                                     gpointer                 user_data,
-                                     GObject                 *list)
+got_added_members_cb (TpConnection            *connection,
+                     guint                    n_contacts,
+                     EmpathyContact * const * contacts,
+                     guint                    n_failed,
+                     const TpHandle          *failed,
+                     const GError            *error,
+                     gpointer                 user_data,
+                     GObject                 *list)
 {
        EmpathyTpContactListPriv *priv = GET_PRIV (list);
        guint i;
@@ -380,9 +391,8 @@ tp_contact_list_got_added_members_cb (EmpathyTpContactFactory *factory,
 
        for (i = 0; i < n_contacts; i++) {
                EmpathyContact *contact = contacts[i];
-               TpHandle handle;
+               TpHandle handle = empathy_contact_get_handle (contact);
 
-               handle = empathy_contact_get_handle (contact);
                if (g_hash_table_lookup (priv->members, GUINT_TO_POINTER (handle)))
                        continue;
 
@@ -391,19 +401,42 @@ tp_contact_list_got_added_members_cb (EmpathyTpContactFactory *factory,
                                     g_object_ref (contact));
                g_signal_emit_by_name (list, "members-changed", contact,
                                       0, 0, NULL, TRUE);
+       }
+}
 
-               /* This contact is now member, implicitly accept pending. */
-               if (g_hash_table_lookup (priv->pendings, GUINT_TO_POINTER (handle))) {
-                       GArray handles = {(gchar *) &handle, 1};
+static void
+add_to_members (EmpathyTpContactList *list,
+               GArray *handles)
+{
+       EmpathyTpContactListPriv *priv = GET_PRIV (list);
+       GArray *request;
+       guint i;
 
-                       tp_cli_channel_interface_group_call_add_members (priv->publish,
-                               -1, &handles, NULL, NULL, NULL, NULL, NULL);
-               }
+       if (handles->len == 0)
+               return;
+
+       request = g_array_new (FALSE, FALSE, sizeof (TpHandle));
+
+       for (i = 0; i < handles->len; i++) {
+               TpHandle handle = g_array_index (handles, TpHandle, i);
+
+               if (g_hash_table_lookup (priv->members, GUINT_TO_POINTER (handle)))
+                       continue;
+
+               g_array_append_val (request, handle);
+       }
+
+       if (request->len > 0) {
+                       empathy_tp_contact_factory_get_from_handles (priv->connection,
+                               request->len, (TpHandle *) request->data,
+                               got_added_members_cb, NULL, NULL, G_OBJECT (list));
        }
+
+       g_array_unref (request);
 }
 
 static void
-tp_contact_list_got_local_pending_cb (EmpathyTpContactFactory *factory,
+tp_contact_list_got_local_pending_cb (TpConnection            *connection,
                                      guint                    n_contacts,
                                      EmpathyContact * const * contacts,
                                      guint                    n_failed,
@@ -425,12 +458,18 @@ tp_contact_list_got_local_pending_cb (EmpathyTpContactFactory *factory,
                TpHandle handle;
                const gchar *message;
                TpChannelGroupChangeReason reason;
+               const TpIntSet *members, *remote_pending;
 
                handle = empathy_contact_get_handle (contact);
-               if (g_hash_table_lookup (priv->members, GUINT_TO_POINTER (handle))) {
+               members = tp_channel_group_get_members (priv->subscribe);
+               remote_pending = tp_channel_group_get_remote_pending (priv->subscribe);
+
+               if (tp_intset_is_member (members, handle) ||
+                   tp_intset_is_member (remote_pending, handle)) {
                        GArray handles = {(gchar *) &handle, 1};
 
-                       /* This contact is already member, auto accept. */
+                       /* This contact is already subscribed, or user requested
+                        * to subscribe, auto accept. */
                        tp_cli_channel_interface_group_call_add_members (priv->publish,
                                -1, &handles, NULL, NULL, NULL, NULL, NULL);
                }
@@ -474,6 +513,29 @@ tp_contact_list_remove_handle (EmpathyTpContactList *list,
        }
 }
 
+static void
+remove_from_member_if_needed (EmpathyTpContactList *list,
+                             TpHandle handle)
+{
+       /* remove contact from members if it's not in publish and subscribe */
+       EmpathyTpContactListPriv *priv = GET_PRIV (list);
+       const TpIntSet *members;
+
+       members = tp_channel_group_get_members (priv->subscribe);
+       if (tp_intset_is_member (members, handle))
+               return;
+
+       members = tp_channel_group_get_remote_pending (priv->subscribe);
+       if (tp_intset_is_member (members, handle))
+               return;
+
+       members = tp_channel_group_get_members (priv->publish);
+       if (tp_intset_is_member (members, handle))
+               return;
+
+       tp_contact_list_remove_handle (list, priv->members, handle);
+}
+
 static void
 tp_contact_list_publish_group_members_changed_cb (TpChannel     *channel,
                                                  gchar         *message,
@@ -489,6 +551,7 @@ tp_contact_list_publish_group_members_changed_cb (TpChannel     *channel,
        guint i;
 
        /* We now send our presence to those contacts, remove them from pendings */
+       add_to_members (list, added);
        for (i = 0; i < added->len; i++) {
                tp_contact_list_remove_handle (list, priv->pendings,
                        g_array_index (added, TpHandle, i));
@@ -496,78 +559,22 @@ tp_contact_list_publish_group_members_changed_cb (TpChannel     *channel,
 
        /* We refuse to send our presence to those contacts, remove from pendings */
        for (i = 0; i < removed->len; i++) {
-               tp_contact_list_remove_handle (list, priv->pendings,
-                       g_array_index (removed, TpHandle, i));
+               TpHandle handle = g_array_index (removed, TpHandle, i);
+
+               tp_contact_list_remove_handle (list, priv->pendings, handle);
+               remove_from_member_if_needed (list, handle);
        }
 
        /* Those contacts want our presence, auto accept those that are already
         * member, otherwise add in pendings. */
        if (local_pending->len > 0) {
-               empathy_tp_contact_factory_get_from_handles (priv->factory,
+               empathy_tp_contact_factory_get_from_handles (priv->connection,
                        local_pending->len, (TpHandle *) local_pending->data,
                        tp_contact_list_got_local_pending_cb, NULL, NULL,
                        G_OBJECT (list));
        }
 }
 
-static void
-tp_contact_list_get_alias_flags_cb (TpConnection *connection,
-                                   guint         flags,
-                                   const GError *error,
-                                   gpointer      user_data,
-                                   GObject      *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-
-       if (error) {
-               DEBUG ("Error: %s", error->message);
-               return;
-       }
-
-       if (flags & TP_CONNECTION_ALIAS_FLAG_USER_SET) {
-               priv->flags |= EMPATHY_CONTACT_LIST_CAN_ALIAS;
-       }
-}
-
-static void
-tp_contact_list_get_requestablechannelclasses_cb (TpProxy      *connection,
-                                                 const GValue *value,
-                                                 const GError *error,
-                                                 gpointer      user_data,
-                                                 GObject      *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-       GPtrArray *classes;
-       guint i;
-
-       if (error) {
-               DEBUG ("Error: %s", error->message);
-               return;
-       }
-
-       classes = g_value_get_boxed (value);
-       for (i = 0; i < classes->len; i++) {
-               GValueArray *class = g_ptr_array_index (classes, i);
-               GHashTable *props;
-               const char *channel_type;
-               guint handle_type;
-
-               props = g_value_get_boxed (g_value_array_get_nth (class, 0));
-
-               channel_type = tp_asv_get_string (props,
-                               TP_IFACE_CHANNEL ".ChannelType");
-               handle_type = tp_asv_get_uint32 (props,
-                               TP_IFACE_CHANNEL ".TargetHandleType", NULL);
-
-               if (!tp_strdiff (channel_type, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST) &&
-                   handle_type == TP_HANDLE_TYPE_GROUP) {
-                       DEBUG ("Got channel class for a contact group");
-                       priv->flags |= EMPATHY_CONTACT_LIST_CAN_GROUP;
-                       break;
-               }
-       }
-}
-
 static void
 tp_contact_list_subscribe_group_members_changed_cb (TpChannel     *channel,
                                                    gchar         *message,
@@ -581,76 +588,62 @@ tp_contact_list_subscribe_group_members_changed_cb (TpChannel     *channel,
 {
        EmpathyTpContactListPriv *priv = GET_PRIV (list);
        guint i;
+       GArray *accept;
 
        /* We now get the presence of those contacts, add them to members */
-       if (added->len > 0) {
-               empathy_tp_contact_factory_get_from_handles (priv->factory,
-                       added->len, (TpHandle *) added->data,
-                       tp_contact_list_got_added_members_cb, NULL, NULL,
-                       G_OBJECT (list));
-       }
+       add_to_members (list, added);
 
        /* Those contacts refuse to send us their presence, remove from members. */
        for (i = 0; i < removed->len; i++) {
-               tp_contact_list_remove_handle (list, priv->members,
-                       g_array_index (removed, TpHandle, i));
+               remove_from_member_if_needed (list, g_array_index (removed, TpHandle, i));
        }
 
        /* We want those contacts in our contact list but we don't get their
         * presence yet. Add to members anyway. */
-       if (remote_pending->len > 0) {
-               empathy_tp_contact_factory_get_from_handles (priv->factory,
-                       remote_pending->len, (TpHandle *) remote_pending->data,
-                       tp_contact_list_got_added_members_cb, NULL, NULL,
-                       G_OBJECT (list));
+       add_to_members (list, remote_pending);
+
+       /* Implicitly accept pending request of contacts which are now members. */
+       if (priv->publish == NULL)
+               return;
+
+       accept = g_array_new (FALSE, FALSE, sizeof (TpHandle));
+       for (i = 0; i < added->len; i++) {
+               TpHandle handle = g_array_index (added, TpHandle, i);
+
+               if (g_hash_table_lookup (priv->pendings, GUINT_TO_POINTER (handle)) != NULL)
+                       g_array_append_val (accept, handle);
        }
-}
 
-static void
-tp_contact_list_new_channel_cb (TpConnection *proxy,
-                               const gchar  *object_path,
-                               const gchar  *channel_type,
-                               guint         handle_type,
-                               guint         handle,
-                               gboolean      suppress_handler,
-                               gpointer      user_data,
-                               GObject      *list)
-{
-       tp_contact_list_group_add_channel (EMPATHY_TP_CONTACT_LIST (list),
-                                          object_path, channel_type,
-                                          handle_type, handle);
+       for (i = 0; i < remote_pending->len; i++) {
+               TpHandle handle = g_array_index (added, TpHandle, i);
+
+               if (g_hash_table_lookup (priv->pendings, GUINT_TO_POINTER (handle)) != NULL)
+                       g_array_append_val (accept, handle);
+       }
+
+       tp_cli_channel_interface_group_call_add_members (priv->publish,
+               -1, accept, NULL, NULL, NULL, NULL, NULL);
+
+       g_array_unref (accept);
 }
 
 static void
-tp_contact_list_list_channels_cb (TpConnection    *connection,
-                                 const GPtrArray *channels,
-                                 const GError    *error,
-                                 gpointer         user_data,
-                                 GObject         *list)
+tp_contact_list_store_group_members_changed_cb (TpChannel     *channel,
+                                               gchar         *message,
+                                               GArray        *added,
+                                               GArray        *removed,
+                                               GArray        *local_pending,
+                                               GArray        *remote_pending,
+                                               guint          actor,
+                                               guint          reason,
+                                               EmpathyTpContactList *list)
 {
        guint i;
 
-       if (error) {
-               DEBUG ("Error: %s", error->message);
-               return;
-       }
+       add_to_members (list, added);
 
-       for (i = 0; i < channels->len; i++) {
-               GValueArray  *chan_struct;
-               const gchar  *object_path;
-               const gchar  *channel_type;
-               TpHandleType  handle_type;
-               guint         handle;
-
-               chan_struct = g_ptr_array_index (channels, i);
-               object_path = g_value_get_boxed (g_value_array_get_nth (chan_struct, 0));
-               channel_type = g_value_get_string (g_value_array_get_nth (chan_struct, 1));
-               handle_type = g_value_get_uint (g_value_array_get_nth (chan_struct, 2));
-               handle = g_value_get_uint (g_value_array_get_nth (chan_struct, 3));
-
-               tp_contact_list_group_add_channel (EMPATHY_TP_CONTACT_LIST (list),
-                                                  object_path, channel_type,
-                                                  handle_type, handle);
+       for (i = 0; i < removed->len; i++) {
+               remove_from_member_if_needed (list, g_array_index (removed, TpHandle, i));
        }
 }
 
@@ -681,33 +674,20 @@ tp_contact_list_finalize (GObject *object)
                g_object_unref (priv->connection);
        }
 
-       if (priv->factory) {
-               g_object_unref (priv->factory);
-       }
-
        g_hash_table_iter_init (&iter, priv->groups);
        while (g_hash_table_iter_next (&iter, NULL, &channel)) {
                g_signal_handlers_disconnect_by_func (channel,
                        tp_contact_list_group_invalidated_cb, list);
        }
 
-       g_hash_table_destroy (priv->groups);
-       g_hash_table_destroy (priv->members);
-       g_hash_table_destroy (priv->pendings);
-       g_hash_table_destroy (priv->add_to_group);
+       g_hash_table_unref (priv->groups);
+       g_hash_table_unref (priv->members);
+       g_hash_table_unref (priv->pendings);
+       g_hash_table_unref (priv->add_to_group);
 
        G_OBJECT_CLASS (empathy_tp_contact_list_parent_class)->finalize (object);
 }
 
-static gboolean
-received_all_list_channels (EmpathyTpContactList *self)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (self);
-
-       return (priv->stored != NULL && priv->publish != NULL &&
-               priv->subscribe != NULL);
-}
-
 static void
 got_list_channel (EmpathyTpContactList *list,
                  TpChannel *channel)
@@ -724,6 +704,9 @@ got_list_channel (EmpathyTpContactList *list,
                if (priv->stored != NULL)
                        return;
                priv->stored = g_object_ref (channel);
+               g_signal_connect (priv->stored, "group-members-changed",
+                                 G_CALLBACK (tp_contact_list_store_group_members_changed_cb),
+                                 list);
        } else if (!tp_strdiff (id, "publish")) {
                if (priv->publish != NULL)
                        return;
@@ -739,12 +722,6 @@ got_list_channel (EmpathyTpContactList *list,
                                  G_CALLBACK (tp_contact_list_subscribe_group_members_changed_cb),
                                  list);
        }
-
-       if (received_all_list_channels (list) && priv->new_channels_sig != NULL) {
-               /* We don't need to watch NewChannels anymore */
-               tp_proxy_signal_connection_disconnect (priv->new_channels_sig);
-               priv->new_channels_sig = NULL;
-       }
 }
 
 static void
@@ -770,20 +747,16 @@ list_ensure_channel_cb (TpConnection *conn,
 }
 
 static void
-new_channels_cb (TpConnection *conn,
-                const GPtrArray *channels,
-                gpointer user_data,
-                GObject *weak_object)
+iterate_on_channels (EmpathyTpContactList *list,
+                    const GPtrArray *channels)
 {
-       EmpathyTpContactList *list = EMPATHY_TP_CONTACT_LIST (weak_object);
        guint i;
 
        for (i = 0; i < channels->len ; i++) {
                GValueArray *arr = g_ptr_array_index (channels, i);
                const gchar *path;
                GHashTable *properties;
-               const gchar *id;
-               TpChannel *channel;
+               TpHandleType handle_type;
 
                path = g_value_get_boxed (g_value_array_get_nth (arr, 0));
                properties = g_value_get_boxed (g_value_array_get_nth (arr, 1));
@@ -791,25 +764,51 @@ new_channels_cb (TpConnection *conn,
                if (tp_strdiff (tp_asv_get_string (properties,
                                TP_IFACE_CHANNEL ".ChannelType"),
                    TP_IFACE_CHANNEL_TYPE_CONTACT_LIST))
-                       return;
+                       continue;
 
-               if (tp_asv_get_uint32 (properties,
-                                      TP_IFACE_CHANNEL ".TargetHandleType", NULL)
-                   != TP_HANDLE_TYPE_LIST)
-                       return;
+               if (tp_asv_get_string (properties, TP_IFACE_CHANNEL ".TargetID") == NULL)
+                       continue;
 
-               id = tp_asv_get_string (properties,
-                                       TP_IFACE_CHANNEL ".TargetID");
-               if (id == NULL)
-                       return;
+               handle_type = tp_asv_get_uint32 (properties,
+                       TP_IFACE_CHANNEL ".TargetHandleType", NULL);
 
-               channel = tp_channel_new_from_properties (conn, path,
-                                                         properties, NULL);
-               got_list_channel (list, channel);
-               g_object_unref (channel);
+               if (handle_type != TP_HANDLE_TYPE_GROUP)
+                       continue;
+
+               tp_contact_list_group_add_channel (list, path, properties);
        }
 }
 
+static void
+new_channels_cb (TpConnection *conn,
+                const GPtrArray *channels,
+                gpointer user_data,
+                GObject *weak_object)
+{
+       EmpathyTpContactList *list = EMPATHY_TP_CONTACT_LIST (weak_object);
+
+       iterate_on_channels (list, channels);
+}
+
+static void
+got_channels_cb (TpProxy *conn,
+                const GValue *out,
+                const GError *error,
+                gpointer user_data,
+                GObject *weak_object)
+{
+       EmpathyTpContactList *list = EMPATHY_TP_CONTACT_LIST (weak_object);
+       const GPtrArray *channels;
+
+       if (error != NULL) {
+               DEBUG ("Get Channels property failed: %s", error->message);
+               return;
+       }
+
+       channels = g_value_get_boxed (out);
+       iterate_on_channels (list, channels);
+}
+
 static void
 conn_ready_cb (TpConnection *connection,
               const GError *error,
@@ -824,34 +823,39 @@ conn_ready_cb (TpConnection *connection,
                goto out;
        }
 
+       /* Look for existing group channels */
+       tp_cli_dbus_properties_call_get (connection, -1,
+               TP_IFACE_CONNECTION_INTERFACE_REQUESTS, "Channels", got_channels_cb,
+               NULL, NULL, G_OBJECT (list));
+
        request = tp_asv_new (
-               TP_IFACE_CHANNEL ".ChannelType", G_TYPE_STRING, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST,
-               TP_IFACE_CHANNEL ".TargetHandleType", G_TYPE_UINT, TP_HANDLE_TYPE_LIST,
+               TP_PROP_CHANNEL_CHANNEL_TYPE, G_TYPE_STRING, TP_IFACE_CHANNEL_TYPE_CONTACT_LIST,
+               TP_PROP_CHANNEL_TARGET_HANDLE_TYPE, G_TYPE_UINT, TP_HANDLE_TYPE_LIST,
                NULL);
 
        /* Watch the NewChannels signal so if ensuring list channels fails (for
         * example because the server is slow and the D-Bus call timeouts before CM
         * fetches the roster), we have a chance to get them later. */
-       priv->new_channels_sig =
-         tp_cli_connection_interface_requests_connect_to_new_channels (
+       tp_cli_connection_interface_requests_connect_to_new_channels (
                priv->connection, new_channels_cb, NULL, NULL, G_OBJECT (list), NULL);
 
        /* Request the 'stored' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "stored");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "stored");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
-               -1, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
+               G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        /* Request the 'publish' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "publish");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "publish");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
-               -1, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
+               G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        /* Request the 'subscribe' list. */
-       tp_asv_set_static_string (request, TP_IFACE_CHANNEL ".TargetID", "subscribe");
+       tp_asv_set_static_string (request, TP_PROP_CHANNEL_TARGET_ID, "subscribe");
        tp_cli_connection_interface_requests_call_ensure_channel (priv->connection,
-               -1, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
+               G_MAXINT, request, list_ensure_channel_cb, list, NULL, G_OBJECT (list));
 
        g_hash_table_unref (request);
+
 out:
        g_object_unref (list);
 }
@@ -860,57 +864,9 @@ static void
 tp_contact_list_constructed (GObject *list)
 {
        EmpathyTpContactListPriv *priv = GET_PRIV (list);
-       gchar                    *protocol_name = NULL;
-
-       priv->factory = empathy_tp_contact_factory_dup_singleton (priv->connection);
-
-       /* call GetAliasFlags */
-       if (tp_proxy_has_interface_by_id (priv->connection,
-                               TP_IFACE_QUARK_CONNECTION_INTERFACE_ALIASING)) {
-               tp_cli_connection_interface_aliasing_call_get_alias_flags (
-                               priv->connection,
-                               -1,
-                               tp_contact_list_get_alias_flags_cb,
-                               NULL, NULL,
-                               G_OBJECT (list));
-       }
-
-       /* lookup RequestableChannelClasses */
-       if (tp_proxy_has_interface_by_id (priv->connection,
-                               TP_IFACE_QUARK_CONNECTION_INTERFACE_REQUESTS)) {
-               tp_cli_dbus_properties_call_get (priv->connection,
-                               -1,
-                               TP_IFACE_CONNECTION_INTERFACE_REQUESTS,
-                               "RequestableChannelClasses",
-                               tp_contact_list_get_requestablechannelclasses_cb,
-                               NULL, NULL,
-                               G_OBJECT (list));
-       } else {
-               /* we just don't know... better mark the flag just in case */
-               priv->flags |= EMPATHY_CONTACT_LIST_CAN_GROUP;
-       }
 
        tp_connection_call_when_ready (priv->connection, conn_ready_cb,
                g_object_ref (list));
-
-       tp_cli_connection_call_list_channels (priv->connection, -1,
-                                             tp_contact_list_list_channels_cb,
-                                             NULL, NULL,
-                                             list);
-
-       tp_cli_connection_connect_to_new_channel (priv->connection,
-                                                 tp_contact_list_new_channel_cb,
-                                                 NULL, NULL,
-                                                 list, NULL);
-
-       /* Check for protocols that does not support contact groups. We can
-        * put all contacts into a special group in that case.
-        * FIXME: Default group should be an information in the profile */
-       tp_connection_parse_object_path (priv->connection, &protocol_name, NULL);
-       if (!tp_strdiff (protocol_name, "local-xmpp")) {
-               priv->protocol_group = _("People nearby");
-       }
-       g_free (protocol_name);
 }
 
 static void
@@ -974,7 +930,7 @@ empathy_tp_contact_list_class_init (EmpathyTpContactListClass *klass)
 static void
 tp_contact_list_array_free (gpointer handles)
 {
-       g_array_free (handles, TRUE);
+       g_array_unref (handles);
 }
 
 static void
@@ -1037,10 +993,12 @@ tp_contact_list_add (EmpathyContactList *list,
        GArray handles = {(gchar *) &handle, 1};
 
        handle = empathy_contact_get_handle (contact);
+
        if (priv->subscribe) {
                tp_cli_channel_interface_group_call_add_members (priv->subscribe,
                        -1, &handles, message, NULL, NULL, NULL, NULL);
        }
+
        if (priv->publish) {
                TpChannelGroupFlags flags = tp_channel_group_get_flags (priv->subscribe);
                if (flags & TP_CHANNEL_GROUP_FLAG_CAN_ADD ||
@@ -1049,6 +1007,15 @@ tp_contact_list_add (EmpathyContactList *list,
                                -1, &handles, message, NULL, NULL, NULL, NULL);
                }
        }
+
+       /* We want to unblock the contact */
+       if (tp_proxy_has_interface_by_id (priv->connection,
+               TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_BLOCKING)) {
+               TpContact *tp_contact = empathy_contact_get_tp_contact (contact);
+
+               if (tp_contact != NULL)
+                       tp_contact_unblock_async (tp_contact, NULL, NULL);
+       }
 }
 
 static void
@@ -1101,24 +1068,6 @@ tp_contact_list_get_pendings (EmpathyContactList *list)
        return ret;
 }
 
-static GList *
-tp_contact_list_get_all_groups (EmpathyContactList *list)
-{
-       EmpathyTpContactListPriv *priv = GET_PRIV (list);
-       GList                    *ret, *l;
-
-       ret = g_hash_table_get_keys (priv->groups);
-       for (l = ret; l; l = l->next) {
-               l->data = g_strdup (l->data);
-       }
-
-       if (priv->protocol_group) {
-               ret = g_list_prepend (ret, g_strdup (priv->protocol_group));
-       }
-
-       return ret;
-}
-
 static GList *
 tp_contact_list_get_groups (EmpathyContactList *list,
                            EmpathyContact     *contact)
@@ -1141,10 +1090,6 @@ tp_contact_list_get_groups (EmpathyContactList *list,
                }
        }
 
-       if (priv->protocol_group) {
-               ret = g_list_prepend (ret, g_strdup (priv->protocol_group));
-       }
-
        return ret;
 }
 
@@ -1236,35 +1181,7 @@ tp_contact_list_remove_group (EmpathyContactList *list,
        tp_cli_channel_interface_group_call_remove_members (channel, -1,
                handles, NULL, NULL, NULL, NULL, NULL);
        tp_cli_channel_call_close (channel, -1, NULL, NULL, NULL, NULL);
-       g_array_free (handles, TRUE);
-}
-
-static EmpathyContactListFlags
-tp_contact_list_get_flags (EmpathyContactList *list)
-{
-       EmpathyTpContactListPriv *priv;
-       EmpathyContactListFlags flags;
-
-       g_return_val_if_fail (EMPATHY_IS_TP_CONTACT_LIST (list), FALSE);
-
-       priv = GET_PRIV (list);
-       flags = priv->flags;
-
-       if (priv->subscribe != NULL) {
-               TpChannelGroupFlags group_flags;
-
-               group_flags = tp_channel_group_get_flags (priv->subscribe);
-
-               if (group_flags & TP_CHANNEL_GROUP_FLAG_CAN_ADD) {
-                       flags |= EMPATHY_CONTACT_LIST_CAN_ADD;
-               }
-
-               if (group_flags & TP_CHANNEL_GROUP_FLAG_CAN_REMOVE) {
-                       flags |= EMPATHY_CONTACT_LIST_CAN_REMOVE;
-               }
-       }
-
-       return flags;
+       g_array_unref (handles);
 }
 
 static void
@@ -1274,13 +1191,11 @@ tp_contact_list_iface_init (EmpathyContactListIface *iface)
        iface->remove            = tp_contact_list_remove;
        iface->get_members       = tp_contact_list_get_members;
        iface->get_pendings      = tp_contact_list_get_pendings;
-       iface->get_all_groups    = tp_contact_list_get_all_groups;
        iface->get_groups        = tp_contact_list_get_groups;
        iface->add_to_group      = tp_contact_list_add_to_group;
        iface->remove_from_group = tp_contact_list_remove_from_group;
        iface->rename_group      = tp_contact_list_rename_group;
        iface->remove_group      = tp_contact_list_remove_group;
-       iface->get_flags         = tp_contact_list_get_flags;
 }
 
 void
@@ -1309,4 +1224,3 @@ empathy_tp_contact_list_remove_all (EmpathyTpContactList *list)
        }
        g_hash_table_remove_all (priv->pendings);
 }
-