]> git.0d.be Git - empathy.git/blobdiff - libempathy-gtk/empathy-log-window.c
Merge remote-tracking branch 'jonny/ft'
[empathy.git] / libempathy-gtk / empathy-log-window.c
index 5ea872e14a6bc701b568e54ef0337616b627be50..af375f1b51f27b86236e8298772dbb85edecc621 100644 (file)
@@ -182,6 +182,7 @@ enum
   COL_WHO_TYPE,
   COL_WHO_ICON,
   COL_WHO_NAME,
+  COL_WHO_NAME_SORT_KEY,
   COL_WHO_ID,
   COL_WHO_ACCOUNT,
   COL_WHO_TARGET,
@@ -297,16 +298,6 @@ ctx_free (Ctx *ctx)
   g_slice_free (Ctx, ctx);
 }
 
-static void
-account_chooser_ready_cb (EmpathyAccountChooser *chooser,
-    EmpathyLogWindow *self)
-{
-  /* We'll display the account once the model has been populate with the chats
-   * of this account. */
-  empathy_account_chooser_set_account (EMPATHY_ACCOUNT_CHOOSER (
-      self->priv->account_chooser), self->priv->selected_account);
-}
-
 static void
 select_account_once_ready (EmpathyLogWindow *self,
     TpAccount *account,
@@ -325,12 +316,8 @@ select_account_once_ready (EmpathyLogWindow *self,
 
   self->priv->selected_is_chatroom = is_chatroom;
 
-  if (empathy_account_chooser_is_ready (account_chooser))
-    account_chooser_ready_cb (account_chooser, self);
-  else
-    /* Chat will be selected once the account chooser is ready */
-    g_signal_connect (account_chooser, "ready",
-        G_CALLBACK (account_chooser_ready_cb), self);
+  empathy_account_chooser_set_account (account_chooser,
+      self->priv->selected_account);
 }
 
 static void
@@ -616,6 +603,7 @@ empathy_log_window_init (EmpathyLogWindow *self)
   GFile *gfile;
   GtkWidget *vbox, *accounts, *search, *label, *closeitem;
   GtkWidget *scrolledwindow_events;
+  gchar *uri;
 
   self->priv = G_TYPE_INSTANCE_GET_PRIVATE (self,
       EMPATHY_TYPE_LOG_WINDOW, EmpathyLogWindowPriv);
@@ -669,7 +657,7 @@ empathy_log_window_init (EmpathyLogWindow *self)
       G_CALLBACK (gtk_widget_destroy), self);
 
   /* Account chooser for chats */
-  vbox = gtk_vbox_new (FALSE, 3);
+  vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 3);
 
   self->priv->account_chooser = empathy_account_chooser_new ();
   account_chooser = EMPATHY_ACCOUNT_CHOOSER (self->priv->account_chooser);
@@ -678,6 +666,9 @@ empathy_log_window_init (EmpathyLogWindow *self)
       empathy_account_chooser_filter_has_logs, NULL);
   empathy_account_chooser_set_all (account_chooser);
 
+  gtk_style_context_add_class (gtk_widget_get_style_context (self->priv->account_chooser),
+                               GTK_STYLE_CLASS_RAISED);
+
   g_signal_connect (self->priv->account_chooser, "changed",
       G_CALLBACK (log_window_chats_accounts_changed_cb),
       self);
@@ -696,13 +687,13 @@ empathy_log_window_init (EmpathyLogWindow *self)
   gtk_container_add (GTK_CONTAINER (accounts), vbox);
 
   /* Search entry */
-  vbox = gtk_vbox_new (FALSE, 3);
+  vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 3);
 
   self->priv->search_entry = gtk_entry_new ();
-  gtk_entry_set_icon_from_stock (GTK_ENTRY (self->priv->search_entry),
-      GTK_ENTRY_ICON_PRIMARY, GTK_STOCK_FIND);
-  gtk_entry_set_icon_from_stock (GTK_ENTRY (self->priv->search_entry),
-      GTK_ENTRY_ICON_SECONDARY, GTK_STOCK_CLEAR);
+  gtk_entry_set_icon_from_icon_name (GTK_ENTRY (self->priv->search_entry),
+      GTK_ENTRY_ICON_SECONDARY, "edit-find-symbolic");
+  gtk_entry_set_icon_sensitive (GTK_ENTRY (self->priv->search_entry),
+                                GTK_ENTRY_ICON_SECONDARY, FALSE);
 
   label = gtk_label_new (_("Search"));
 
@@ -755,9 +746,10 @@ empathy_log_window_init (EmpathyLogWindow *self)
   gfile = g_file_new_for_path (filename);
   g_free (filename);
 
-  webkit_web_view_load_uri (WEBKIT_WEB_VIEW (self->priv->webview),
-      g_file_get_uri (gfile));
+  uri = g_file_get_uri (gfile);
+  webkit_web_view_load_uri (WEBKIT_WEB_VIEW (self->priv->webview), uri);
   g_object_unref (gfile);
+  g_free (uri);
 
   /* handle all navigation externally */
   g_signal_connect (self->priv->webview, "navigation-policy-decision-requested",
@@ -1367,13 +1359,24 @@ log_window_append_call (TplEvent *event,
   if (tpl_call_event_get_end_reason (call) != TPL_CALL_END_REASON_NO_ANSWER)
     {
       gchar *body;
+      gchar *tmp;
 
       span = tpl_call_event_get_duration (TPL_CALL_EVENT (event));
+
       if (span < 60)
-        duration = g_strdup_printf (_("%" G_GINT64_FORMAT " seconds"), span);
+        {
+          tmp = g_strdup_printf ("%" G_GINT64_FORMAT, span);
+          duration = g_strdup_printf (
+              ngettext ("%s second", "%s seconds", span), tmp);
+          g_free (tmp);
+        }
       else
-        duration = g_strdup_printf (_("%" G_GINT64_FORMAT " minutes"),
-            span / 60);
+        {
+          tmp = g_strdup_printf ("%" G_GINT64_FORMAT, span / 60);
+          duration = g_strdup_printf (
+              ngettext ("%s minute", "%s minutes", span / 60), tmp);
+          g_free (tmp);
+        }
 
       finished_date = g_date_time_add (started_date, -span);
       finished = g_date_time_format (finished_date, "%X");
@@ -1619,9 +1622,11 @@ model_has_date (GtkTreeModel *model,
   if (!g_date_compare (date, d))
     {
       has_element = TRUE;
+      g_date_free (d);
       return TRUE;
     }
 
+  g_date_free (d);
   return FALSE;
 }
 
@@ -1729,9 +1734,8 @@ format_date_for_display (GDate *date)
         text = g_date_time_format (dt, "%A");
       else
         text = g_date_time_format (dt,
-            C_("A date such as '23 May 2010', "
-               "%e is the day, %B the month and %Y the year",
-               "%e %B %Y"));
+            /* Translators: A date such as '23 May 2010' (strftime format) */
+            _("%e %B %Y"));
 
       g_date_time_unref (dt);
     }
@@ -1803,18 +1807,27 @@ populate_dates_from_search_hits (GList *accounts,
 
   if (gtk_tree_model_get_iter_first (model, &iter))
     {
+      GDate *date;
+
+      date = g_date_new_dmy (1, 1, -1),
+
       gtk_list_store_prepend (store, &iter);
       gtk_list_store_set (store, &iter,
-          COL_WHEN_DATE, g_date_new_dmy (1, 1, -1),
+          COL_WHEN_DATE, date,
           COL_WHEN_TEXT, "separator",
           -1);
 
+      g_date_free (date);
+
+      date = g_date_new_dmy (2, 1, -1),
       gtk_list_store_prepend (store, &iter);
       gtk_list_store_set (store, &iter,
-          COL_WHEN_DATE, g_date_new_dmy (2, 1, -1),
+          COL_WHEN_DATE, date,
           COL_WHEN_TEXT, _("Anytime"),
           -1);
 
+      g_date_free (date);
+
       if (gtk_tree_model_iter_nth_child (model, &iter, NULL, 2))
         gtk_tree_selection_select_iter (selection, &iter);
     }
@@ -1861,22 +1874,29 @@ populate_entities_from_search_hits (void)
         {
           TplEntityType type = tpl_entity_get_entity_type (hit->target);
           EmpathyContact *contact;
+          const gchar *name;
+          gchar *sort_key;
           gboolean room = type == TPL_ENTITY_ROOM;
 
           contact = empathy_contact_from_tpl_contact (hit->account,
               hit->target);
 
+          name = empathy_contact_get_alias (contact);
+          sort_key = g_utf8_collate_key (name, -1);
+
           gtk_list_store_append (store, &iter);
           gtk_list_store_set (store, &iter,
               COL_WHO_TYPE, COL_TYPE_NORMAL,
               COL_WHO_ICON, room ? EMPATHY_IMAGE_GROUP_MESSAGE
                                  : EMPATHY_IMAGE_AVATAR_DEFAULT,
-              COL_WHO_NAME, empathy_contact_get_alias (contact),
+              COL_WHO_NAME, name,
+              COL_WHO_NAME_SORT_KEY, sort_key,
               COL_WHO_ID, tpl_entity_get_identifier (hit->target),
               COL_WHO_ACCOUNT, hit->account,
               COL_WHO_TARGET, hit->target,
               -1);
 
+          g_free (sort_key);
           g_object_unref (contact);
         }
     }
@@ -2004,6 +2024,25 @@ static void
 log_window_search_entry_changed_cb (GtkWidget *entry,
     EmpathyLogWindow *self)
 {
+  const gchar *str;
+
+  str = gtk_entry_get_text (GTK_ENTRY (self->priv->search_entry));
+
+  if (!tp_str_empty (str))
+    {
+      gtk_entry_set_icon_from_icon_name (GTK_ENTRY (self->priv->search_entry),
+          GTK_ENTRY_ICON_SECONDARY, "edit-clear-symbolic");
+      gtk_entry_set_icon_sensitive (GTK_ENTRY (self->priv->search_entry),
+          GTK_ENTRY_ICON_SECONDARY, TRUE);
+    }
+  else
+    {
+      gtk_entry_set_icon_from_icon_name (GTK_ENTRY (self->priv->search_entry),
+          GTK_ENTRY_ICON_SECONDARY, "edit-find-symbolic");
+      gtk_entry_set_icon_sensitive (GTK_ENTRY (self->priv->search_entry),
+          GTK_ENTRY_ICON_SECONDARY, FALSE);
+    }
+
   if (self->priv->source != 0)
     g_source_remove (self->priv->source);
   self->priv->source = g_timeout_add (500, (GSourceFunc) start_find_search,
@@ -2279,21 +2318,28 @@ log_manager_got_entities_cb (GObject *manager,
       TplEntity *entity = TPL_ENTITY (l->data);
       TplEntityType type = tpl_entity_get_entity_type (entity);
       EmpathyContact *contact;
+      const gchar *name;
+      gchar *sort_key;
       gboolean room = type == TPL_ENTITY_ROOM;
 
       contact = empathy_contact_from_tpl_contact (ctx->account, entity);
 
+      name = empathy_contact_get_alias (contact);
+      sort_key = g_utf8_collate_key (name, -1);
+
       gtk_list_store_append (store, &iter);
       gtk_list_store_set (store, &iter,
           COL_WHO_TYPE, COL_TYPE_NORMAL,
           COL_WHO_ICON, room ? EMPATHY_IMAGE_GROUP_MESSAGE
                              : EMPATHY_IMAGE_AVATAR_DEFAULT,
-          COL_WHO_NAME, empathy_contact_get_alias (contact),
+          COL_WHO_NAME, name,
+          COL_WHO_NAME_SORT_KEY, sort_key,
           COL_WHO_ID, tpl_entity_get_identifier (entity),
           COL_WHO_ACCOUNT, ctx->account,
           COL_WHO_TARGET, entity,
           -1);
 
+      g_free (sort_key);
       g_object_unref (contact);
 
       if (ctx->self->priv->selected_account != NULL &&
@@ -2445,23 +2491,23 @@ log_window_who_populate (EmpathyLogWindow *self)
 }
 
 static gint
-sort_by_name (GtkTreeModel *model,
+sort_by_name_key (GtkTreeModel *model,
     GtkTreeIter *a,
     GtkTreeIter *b,
     gpointer user_data)
 {
-  gchar *name1, *name2;
+  gchar *key1, *key2;
   gint type1, type2;
   gint ret;
 
   gtk_tree_model_get (model, a,
       COL_WHO_TYPE, &type1,
-      COL_WHO_NAME, &name1,
+      COL_WHO_NAME_SORT_KEY, &key1,
       -1);
 
   gtk_tree_model_get (model, b,
       COL_WHO_TYPE, &type2,
-      COL_WHO_NAME, &name2,
+      COL_WHO_NAME_SORT_KEY, &key2,
       -1);
 
   if (type1 == COL_TYPE_ANY)
@@ -2473,10 +2519,10 @@ sort_by_name (GtkTreeModel *model,
   else if (type2 == COL_TYPE_SEPARATOR)
     ret = 1;
   else
-    ret = g_strcmp0 (name1, name2);
+    ret = g_strcmp0 (key1, key2);
 
-  g_free (name1);
-  g_free (name2);
+  g_free (key1);
+  g_free (key2);
 
   return ret;
 }
@@ -2623,6 +2669,7 @@ log_window_who_setup (EmpathyLogWindow *self)
       G_TYPE_INT,           /* type */
       G_TYPE_STRING,        /* icon */
       G_TYPE_STRING,        /* name */
+      G_TYPE_STRING,        /* name sort key */
       G_TYPE_STRING,        /* id */
       TP_TYPE_ACCOUNT,      /* account */
       TPL_TYPE_ENTITY);     /* target */
@@ -2657,10 +2704,10 @@ log_window_who_setup (EmpathyLogWindow *self)
       NULL, NULL);
 
   gtk_tree_sortable_set_sort_column_id (sortable,
-      COL_WHO_NAME,
+      COL_WHO_NAME_SORT_KEY,
       GTK_SORT_ASCENDING);
   gtk_tree_sortable_set_sort_func (sortable,
-      COL_WHO_NAME, sort_by_name,
+      COL_WHO_NAME_SORT_KEY, sort_by_name_key,
       NULL, NULL);
 
   gtk_tree_view_set_search_column (view, COL_WHO_NAME);
@@ -2748,6 +2795,7 @@ sort_by_date (GtkTreeModel *model,
     gpointer user_data)
 {
   GDate *date1, *date2;
+  gint result;
 
   gtk_tree_model_get (model, a,
       COL_WHEN_DATE, &date1,
@@ -2757,7 +2805,11 @@ sort_by_date (GtkTreeModel *model,
       COL_WHEN_DATE, &date2,
       -1);
 
-  return g_date_compare (date1, date2);
+  result =  g_date_compare (date1, date2);
+
+  g_date_free (date1);
+  g_date_free (date2);
+  return result;
 }
 
 static gboolean
@@ -3300,6 +3352,8 @@ log_window_get_messages_for_dates (EmpathyLogWindow *self,
                           event_mask, subtype, self->priv->count);
                       _tpl_action_chain_append (self->priv->chain, get_events_for_date, ctx);
                     }
+
+                  g_date_free (d);
                 }
             }
         }
@@ -3384,18 +3438,30 @@ log_manager_got_dates_cb (GObject *manager,
 
       if (g_strcmp0 (separator, "separator") != 0)
         {
+          GDate *date;
+
+          date = g_date_new_dmy (1, 1, -1);
+
           gtk_list_store_prepend (store, &iter);
           gtk_list_store_set (store, &iter,
-              COL_WHEN_DATE, g_date_new_dmy (1, 1, -1),
+              COL_WHEN_DATE, date,
               COL_WHEN_TEXT, "separator",
               -1);
 
+          g_date_free (date);
+
+          date = g_date_new_dmy (2, 1, -1);
+
           gtk_list_store_prepend (store, &iter);
           gtk_list_store_set (store, &iter,
-              COL_WHEN_DATE, g_date_new_dmy (2, 1, -1),
+              COL_WHEN_DATE, date,
               COL_WHEN_TEXT, _("Anytime"),
               -1);
+
+          g_date_free (date);
         }
+
+      g_free (separator);
     }
 
   g_list_free_full (dates, g_free);
@@ -3652,22 +3718,10 @@ log_window_logger_clear_account_cb (TpProxy *proxy,
   gtk_tree_store_clear (self->priv->store_events);
   log_window_who_populate (self);
 
-  /* Re-filter the account chooser so the accounts without logs get greyed out */
-  empathy_account_chooser_set_filter (
-      EMPATHY_ACCOUNT_CHOOSER (self->priv->account_chooser),
-      empathy_account_chooser_filter_has_logs, NULL);
-}
-
-static void
-log_window_clear_logs_chooser_select_account (EmpathyAccountChooser *chooser,
-    EmpathyLogWindow *self)
-{
-  EmpathyAccountChooser *account_chooser;
-
-  account_chooser = EMPATHY_ACCOUNT_CHOOSER (self->priv->account_chooser);
-
-  empathy_account_chooser_set_account (chooser,
-      empathy_account_chooser_get_account (account_chooser));
+  /* Re-filter the account chooser so the accounts without logs get
+   * greyed out */
+  empathy_account_chooser_refilter (
+      EMPATHY_ACCOUNT_CHOOSER (self->priv->account_chooser));
 }
 
 static void
@@ -3683,15 +3737,13 @@ log_window_delete_menu_clicked_cb (GtkMenuItem *menuitem,
 
   account_chooser = (EmpathyAccountChooser *) empathy_account_chooser_new ();
   empathy_account_chooser_set_has_all_option (account_chooser, TRUE);
-  empathy_account_chooser_set_filter (account_chooser,
-      empathy_account_chooser_filter_has_logs, NULL);
+
+  empathy_account_chooser_refilter (account_chooser);
 
   /* Select the same account as in the history window */
-  if (empathy_account_chooser_is_ready (account_chooser))
-    log_window_clear_logs_chooser_select_account (account_chooser, self);
-  else
-    g_signal_connect (account_chooser, "ready",
-        G_CALLBACK (log_window_clear_logs_chooser_select_account), self);
+  empathy_account_chooser_set_account (account_chooser,
+      empathy_account_chooser_get_account (
+        EMPATHY_ACCOUNT_CHOOSER (self->priv->account_chooser)));
 
   dialog = gtk_message_dialog_new_with_markup (GTK_WINDOW (self),
       GTK_DIALOG_MODAL, GTK_MESSAGE_WARNING,
@@ -3706,7 +3758,7 @@ log_window_delete_menu_clicked_cb (GtkMenuItem *menuitem,
   content_area = gtk_message_dialog_get_message_area (
       GTK_MESSAGE_DIALOG (dialog));
 
-  hbox = gtk_hbox_new (FALSE, 6);
+  hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 6);
   label = gtk_label_new (_("Delete from:"));
   gtk_box_pack_start (GTK_BOX (hbox), label,
       FALSE, FALSE, 0);