]> git.0d.be Git - empathy.git/blobdiff - libempathy-gtk/empathy-contact-list-view.c
More flexible API for EmpathyContactWidget, we now have flags to set
[empathy.git] / libempathy-gtk / empathy-contact-list-view.c
index 2a5cf3406c107d24edea38045ccbda31e2094cef..e3816dda7ba8a5159db5e410e0de02531935940b 100644 (file)
 #include <gtk/gtk.h>
 #include <glade/glade.h>
 
+#include <libtelepathy/tp-helpers.h>
+
 #include <libmissioncontrol/mc-account.h>
 #include <libmissioncontrol/mission-control.h>
 
-#include <libempathy/empathy-contact-manager.h>
+#include <libempathy/empathy-contact-factory.h>
 #include <libempathy/empathy-contact-list.h>
 #include <libempathy/empathy-log-manager.h>
+#include <libempathy/empathy-tp-group.h>
 #include <libempathy/empathy-debug.h>
 #include <libempathy/empathy-utils.h>
 #include <libempathy/empathy-marshal.h>
@@ -47,6 +50,7 @@
 #include "empathy-contact-groups.h"
 #include "empathy-cell-renderer-expander.h"
 #include "empathy-cell-renderer-text.h"
+#include "empathy-cell-renderer-activatable.h"
 #include "empathy-ui-utils.h"
 #include "empathy-contact-dialogs.h"
 //#include "empathy-chat-invite.h"
 
 struct _EmpathyContactListViewPriv {
        EmpathyContactListStore *store;
-       GtkUIManager           *ui;
-       GtkTreeRowReference    *drag_row;
-       GtkTreeModel           *filter;
-       gchar                  *filter_text;
-
-       EmpathyContactListViewDragReceivedFunc drag_received;
-       gpointer                              drag_received_data;
+       GtkUIManager            *ui;
+       GtkTreeRowReference     *drag_row;
+       gboolean                 interactive;
 };
 
 typedef struct {
@@ -103,11 +103,6 @@ static void        contact_list_view_row_has_child_toggled_cb  (GtkTreeModel
                                                                GtkTreePath                *path,
                                                                GtkTreeIter                *iter,
                                                                EmpathyContactListView      *view);
-static void        contact_list_view_contact_received          (EmpathyContactListView      *view,
-                                                               EmpathyContact              *contact,
-                                                               GdkDragAction               action,
-                                                               const gchar                *old_group,
-                                                               const gchar                *new_group);
 static void        contact_list_view_drag_data_received        (GtkWidget                  *widget,
                                                                GdkDragContext             *context,
                                                                gint                        x,
@@ -143,7 +138,14 @@ static void        contact_list_view_pixbuf_cell_data_func     (GtkTreeViewColum
                                                                GtkCellRenderer            *cell,
                                                                GtkTreeModel               *model,
                                                                GtkTreeIter                *iter,
-                                                               EmpathyContactListView      *view);
+                                                               EmpathyContactListView     *view);
+#ifdef HAVE_VOIP
+static void        contact_list_view_voip_cell_data_func       (GtkTreeViewColumn          *tree_column,
+                                                               GtkCellRenderer            *cell,
+                                                               GtkTreeModel               *model,
+                                                               GtkTreeIter                *iter,
+                                                               EmpathyContactListView     *view);
+#endif
 static void        contact_list_view_avatar_cell_data_func     (GtkTreeViewColumn          *tree_column,
                                                                GtkCellRenderer            *cell,
                                                                GtkTreeModel               *model,
@@ -161,7 +163,8 @@ static void        contact_list_view_expander_cell_data_func   (GtkTreeViewColum
                                                                EmpathyContactListView      *view);
 static GtkWidget * contact_list_view_get_contact_menu          (EmpathyContactListView      *view,
                                                                gboolean                    can_send_file,
-                                                               gboolean                    can_show_log);
+                                                               gboolean                    can_show_log,
+                                                               gboolean                    can_voip);
 static gboolean    contact_list_view_button_press_event_cb     (EmpathyContactListView      *view,
                                                                GdkEventButton             *event,
                                                                gpointer                    user_data);
@@ -169,26 +172,25 @@ static void        contact_list_view_row_activated_cb          (EmpathyContactLi
                                                                GtkTreePath                *path,
                                                                GtkTreeViewColumn          *col,
                                                                gpointer                    user_data);
+#ifdef HAVE_VOIP
+static void        contact_list_view_voip_activated_cb         (EmpathyCellRendererActivatable *cell,
+                                                               const gchar                *path_string,
+                                                               EmpathyContactListView     *view);
+#endif
 static void        contact_list_view_row_expand_or_collapse_cb (EmpathyContactListView      *view,
                                                                GtkTreeIter                *iter,
                                                                GtkTreePath                *path,
                                                                gpointer                    user_data);
-static gboolean    contact_list_view_filter_show_contact       (EmpathyContact              *contact,
-                                                               const gchar                *filter);
-static gboolean    contact_list_view_filter_show_group         (EmpathyContactListView      *view,
-                                                               const gchar                *group,
-                                                               const gchar                *filter);
-static gboolean    contact_list_view_filter_func               (GtkTreeModel               *model,
-                                                               GtkTreeIter                *iter,
-                                                               EmpathyContactListView      *view);
 static void        contact_list_view_action_cb                 (GtkAction                  *action,
                                                                EmpathyContactListView      *view);
 static void        contact_list_view_action_activated          (EmpathyContactListView      *view,
                                                                EmpathyContact              *contact);
+static void        contact_list_view_voip_activated            (EmpathyContactListView      *view,
+                                                               EmpathyContact              *contact);
 
 enum {
        PROP_0,
-       PROP_FILTER,
+       PROP_INTERACTIVE
 };
 
 static const GtkActionEntry entries[] = {
@@ -232,6 +234,12 @@ static const GtkActionEntry entries[] = {
          N_("_View Previous Conversations"), NULL, N_("View previous conversations with this contact"),
          G_CALLBACK (contact_list_view_action_cb)
        },
+#ifdef HAVE_VOIP
+       { "Call", EMPATHY_IMAGE_VOIP,
+         N_("_Call"), NULL, N_("Start a voice or video conversation with this contact"),
+         G_CALLBACK (contact_list_view_action_cb)
+       },
+#endif
 };
 
 static guint n_entries = G_N_ELEMENTS (entries);
@@ -240,6 +248,9 @@ static const gchar *ui_info =
        "<ui>"
        "  <popup name='Contact'>"
        "    <menuitem action='Chat'/>"
+#ifdef HAVE_VOIP
+       "    <menuitem action='Call'/>"
+#endif
        "    <menuitem action='Log'/>"
        "    <menuitem action='SendFile'/>"
        "    <separator/>"
@@ -316,12 +327,12 @@ empathy_contact_list_view_class_init (EmpathyContactListViewClass *klass)
                              3, EMPATHY_TYPE_CONTACT, G_TYPE_STRING, G_TYPE_STRING);
 
        g_object_class_install_property (object_class,
-                                        PROP_FILTER,
-                                        g_param_spec_string ("filter",
-                                                             "Filter",
-                                                             "The text to use to filter the contact list",
-                                                             NULL,
-                                                             G_PARAM_READWRITE));
+                                        PROP_INTERACTIVE,
+                                        g_param_spec_boolean ("interactive",
+                                                              "View is interactive",
+                                                              "Is the view interactive",
+                                                              FALSE,
+                                                              G_PARAM_READWRITE));
 
        g_type_class_add_private (object_class, sizeof (EmpathyContactListViewPriv));
 }
@@ -389,10 +400,6 @@ contact_list_view_finalize (GObject *object)
        if (priv->store) {
                g_object_unref (priv->store);
        }
-       if (priv->filter) {
-               g_object_unref (priv->filter);
-       }
-       g_free (priv->filter_text);
 
        G_OBJECT_CLASS (empathy_contact_list_view_parent_class)->finalize (object);
 }
@@ -408,8 +415,8 @@ contact_list_view_get_property (GObject    *object,
        priv = GET_PRIV (object);
 
        switch (param_id) {
-       case PROP_FILTER:
-               g_value_set_string (value, priv->filter_text);
+       case PROP_INTERACTIVE:
+               g_value_set_boolean (value, priv->interactive);
                break;
        default:
                G_OBJECT_WARN_INVALID_PROPERTY_ID (object, param_id, pspec);
@@ -423,14 +430,14 @@ contact_list_view_set_property (GObject      *object,
                                const GValue *value,
                                GParamSpec   *pspec)
 {
+       EmpathyContactListView     *view = EMPATHY_CONTACT_LIST_VIEW (object);
        EmpathyContactListViewPriv *priv;
 
        priv = GET_PRIV (object);
 
        switch (param_id) {
-       case PROP_FILTER:
-               empathy_contact_list_view_set_filter (EMPATHY_CONTACT_LIST_VIEW (object),
-                                               g_value_get_string (value));
+       case PROP_INTERACTIVE:
+               empathy_contact_list_view_set_interactive (view, g_value_get_boolean (value));
                break;
        default:
                G_OBJECT_WARN_INVALID_PROPERTY_ID (object, param_id, pspec);
@@ -453,6 +460,28 @@ empathy_contact_list_view_new (EmpathyContactListStore *store)
        return view;
 }
 
+void
+empathy_contact_list_view_set_interactive (EmpathyContactListView  *view,
+                                          gboolean                 interactive)
+{
+       EmpathyContactListViewPriv *priv = GET_PRIV (view);
+
+       g_return_if_fail (EMPATHY_IS_CONTACT_LIST_VIEW (view));
+
+       priv->interactive = interactive;
+       g_object_notify (G_OBJECT (view), "interactive");
+}
+
+gboolean
+empathy_contact_list_view_get_interactive (EmpathyContactListView  *view)
+{
+       EmpathyContactListViewPriv *priv = GET_PRIV (view);
+
+       g_return_val_if_fail (EMPATHY_IS_CONTACT_LIST_VIEW (view), FALSE);
+
+       return priv->interactive;
+}
+
 EmpathyContact *
 empathy_contact_list_view_get_selected (EmpathyContactListView *view)
 {
@@ -525,11 +554,12 @@ empathy_contact_list_view_get_group_menu (EmpathyContactListView *view)
 
 GtkWidget *
 empathy_contact_list_view_get_contact_menu (EmpathyContactListView *view,
-                                          EmpathyContact         *contact)
+                                           EmpathyContact         *contact)
 {
        EmpathyLogManager *log_manager;
        gboolean           can_show_log;
        gboolean           can_send_file;
+       gboolean           can_voip;
 
        g_return_val_if_fail (EMPATHY_IS_CONTACT_LIST_VIEW (view), NULL);
        g_return_val_if_fail (EMPATHY_IS_CONTACT (contact), NULL);
@@ -539,53 +569,14 @@ empathy_contact_list_view_get_contact_menu (EmpathyContactListView *view,
                                                   empathy_contact_get_account (contact),
                                                   empathy_contact_get_id (contact),
                                                   FALSE);
-       can_send_file = FALSE;
        g_object_unref (log_manager);
+       can_send_file = FALSE;
+       can_voip = empathy_contact_can_voip (contact);
 
        return contact_list_view_get_contact_menu (view,
                                                   can_send_file,
-                                                  can_show_log);
-}
-
-void
-empathy_contact_list_view_set_filter (EmpathyContactListView *view,
-                                    const gchar           *filter)
-{
-       EmpathyContactListViewPriv *priv;
-
-       g_return_if_fail (EMPATHY_IS_CONTACT_LIST_VIEW (view));
-
-       priv = GET_PRIV (view);
-
-       g_free (priv->filter_text);
-       if (filter) {
-               priv->filter_text = g_utf8_casefold (filter, -1);
-       } else {
-               priv->filter_text = NULL;
-       }
-
-       empathy_debug (DEBUG_DOMAIN, "Refiltering with filter:'%s' (case folded)", filter);
-       gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (priv->filter));
-}
-
-void
-empathy_contact_list_view_set_drag_received_func (EmpathyContactListView                 *view,
-                                                EmpathyContactListViewDragReceivedFunc  func,
-                                                gpointer                               user_data)
-{
-       EmpathyContactListViewPriv *priv;
-
-       g_return_if_fail (EMPATHY_IS_CONTACT_LIST_VIEW (view));
-
-       priv = GET_PRIV (view);
-
-       if (func) {
-               priv->drag_received = func;
-               priv->drag_received_data = user_data;
-       } else {
-               priv->drag_received = NULL;
-               priv->drag_received_data = NULL;
-       }
+                                                  can_show_log,
+                                                  can_voip);
 }
 
 static void
@@ -598,21 +589,15 @@ contact_list_view_setup (EmpathyContactListView *view)
 
        priv = GET_PRIV (view);
 
-       /* Create filter */
-       priv->filter = gtk_tree_model_filter_new (GTK_TREE_MODEL (priv->store), NULL);
-
-       gtk_tree_model_filter_set_visible_func (GTK_TREE_MODEL_FILTER (priv->filter),
-                                               (GtkTreeModelFilterVisibleFunc)
-                                               contact_list_view_filter_func,
-                                               view, NULL);
        gtk_tree_view_set_search_equal_func (GTK_TREE_VIEW (view),
                                             empathy_contact_list_store_search_equal_func,
-                                            view, NULL);
-       g_signal_connect (priv->filter, "row-has-child-toggled",
+                                            NULL, NULL);
+
+       g_signal_connect (priv->store, "row-has-child-toggled",
                          G_CALLBACK (contact_list_view_row_has_child_toggled_cb),
                          view);
-       gtk_tree_view_set_model (GTK_TREE_VIEW (view), priv->filter);
-
+       gtk_tree_view_set_model (GTK_TREE_VIEW (view),
+                                GTK_TREE_MODEL (priv->store));
 
        /* Setup view */
        g_object_set (view,
@@ -652,6 +637,24 @@ contact_list_view_setup (EmpathyContactListView *view)
        gtk_tree_view_column_add_attribute (col, cell,
                                            "is_group", COL_IS_GROUP);
 
+#ifdef HAVE_VOIP
+       /* Voip Capability Icon */
+       cell = empathy_cell_renderer_activatable_new ();
+       gtk_tree_view_column_pack_start (col, cell, FALSE);
+       gtk_tree_view_column_set_cell_data_func (
+               col, cell,
+               (GtkTreeCellDataFunc) contact_list_view_voip_cell_data_func,
+               view, NULL);
+
+       g_object_set (cell,
+                     "visible", FALSE,
+                     NULL);
+
+       g_signal_connect (cell, "path-activated",
+                         G_CALLBACK (contact_list_view_voip_activated_cb),
+                         view);
+#endif
+
        /* Avatar */
        cell = gtk_cell_renderer_pixbuf_new ();
        gtk_tree_view_column_pack_start (col, cell, FALSE);
@@ -697,13 +700,13 @@ contact_list_view_setup (EmpathyContactListView *view)
                             GDK_BUTTON1_MASK,
                             drag_types_source,
                             G_N_ELEMENTS (drag_types_source),
-                            GDK_ACTION_MOVE);
+                            GDK_ACTION_MOVE | GDK_ACTION_COPY);
 
        gtk_drag_dest_set (GTK_WIDGET (view),
                           GTK_DEST_DEFAULT_ALL,
                           drag_types_dest,
                           G_N_ELEMENTS (drag_types_dest),
-                          GDK_ACTION_MOVE | GDK_ACTION_LINK);
+                          GDK_ACTION_MOVE | GDK_ACTION_COPY);
 }
 
 static void
@@ -746,46 +749,6 @@ contact_list_view_row_has_child_toggled_cb (GtkTreeModel          *model,
        g_free (name);
 }
 
-static void
-contact_list_view_contact_received (EmpathyContactListView *view,
-                                   EmpathyContact         *contact,
-                                   GdkDragAction          action,
-                                   const gchar           *old_group,
-                                   const gchar           *new_group)
-{
-       EmpathyContactListViewPriv *priv;
-       GList                     *groups, *l;
-       GList                     *new_groups_list = NULL;
-
-       priv = GET_PRIV (view);
-
-       groups = empathy_contact_get_groups (contact);
-       for (l = groups; l; l = l->next) {
-               gchar *str;
-
-               str = l->data;
-
-               if (action == GDK_ACTION_MOVE &&
-                   old_group != NULL &&
-                   strcmp (str, old_group) == 0) {
-                       continue;
-               }
-
-               if (new_group && strcmp (str, new_group) == 0) {
-                       /* Otherwise we set it twice */
-                       continue;
-               }
-
-               new_groups_list = g_list_prepend (new_groups_list, g_strdup (str));
-       }
-
-       if (new_group) {
-               new_groups_list = g_list_prepend (new_groups_list, g_strdup (new_group));
-       }
-
-       empathy_contact_set_groups (contact, new_groups_list);
-}
-
 static void
 contact_list_view_drag_data_received (GtkWidget         *widget,
                                      GdkDragContext    *context,
@@ -796,15 +759,18 @@ contact_list_view_drag_data_received (GtkWidget         *widget,
                                      guint              time)
 {
        EmpathyContactListViewPriv *priv;
-       EmpathyContactList        *list;
-       GtkTreeModel              *model;
-       GtkTreePath               *path;
-       GtkTreeViewDropPosition    position;
-       EmpathyContact             *contact;
-       const gchar               *id;
-       gchar                     *new_group = NULL;
-       gchar                     *old_group = NULL;
-       gboolean                   is_row;
+       EmpathyContactList         *list;
+       EmpathyContactFactory      *factory;
+       McAccount                  *account;
+       GtkTreeModel               *model;
+       GtkTreePath                *path;
+       GtkTreeViewDropPosition     position;
+       EmpathyContact             *contact = NULL;
+       const gchar                *id;
+       gchar                     **strv;
+       gchar                      *new_group = NULL;
+       gchar                      *old_group = NULL;
+       gboolean                    is_row;
 
        priv = GET_PRIV (widget);
 
@@ -814,9 +780,17 @@ contact_list_view_drag_data_received (GtkWidget         *widget,
                      context->action == GDK_ACTION_COPY ? "copy" : "",
                      id);
 
-       /* FIXME: This is ambigous, an id can come from multiple accounts */
-       list = empathy_contact_list_store_get_list_iface (priv->store);
-       contact = empathy_contact_list_find (list, id);
+       strv = g_strsplit (id, "/", 2);
+       factory = empathy_contact_factory_new ();
+       account = mc_account_lookup (strv[0]);
+       if (account) {
+               contact = empathy_contact_factory_get_from_id (factory,
+                                                              account,
+                                                              strv[1]);
+               g_object_unref (account);
+       }
+       g_object_unref (factory);
+       g_strfreev (strv);
 
        if (!contact) {
                empathy_debug (DEBUG_DOMAIN, "No contact found associated with drag & drop");
@@ -847,22 +821,17 @@ contact_list_view_drag_data_received (GtkWidget         *widget,
        }
 
        empathy_debug (DEBUG_DOMAIN,
-                     "contact '%s' dragged from '%s' to '%s'",
-                     empathy_contact_get_name (contact),
+                     "contact %s (%d) dragged from '%s' to '%s'",
+                     empathy_contact_get_id (contact),
+                     empathy_contact_get_handle (contact),
                      old_group, new_group);
 
-       if (priv->drag_received) {
-               priv->drag_received (contact,
-                                    context->action,
-                                    old_group,
-                                    new_group,
-                                    priv->drag_received_data);
-       } else {
-               contact_list_view_contact_received (EMPATHY_CONTACT_LIST_VIEW (widget),
-                                                   contact,
-                                                   context->action,
-                                                   old_group,
-                                                   new_group);
+       list = empathy_contact_list_store_get_list_iface (priv->store);
+       if (new_group) {
+               empathy_contact_list_add_to_group (list, contact, new_group);
+       }
+       if (old_group && context->action == GDK_ACTION_MOVE) {  
+               empathy_contact_list_remove_from_group (list, contact, old_group);
        }
 
        g_free (old_group);
@@ -976,11 +945,15 @@ contact_list_view_drag_data_get (GtkWidget        *widget,
                                 guint             time)
 {
        EmpathyContactListViewPriv *priv;
-       GtkTreePath               *src_path;
-       GtkTreeIter                iter;
-       GtkTreeModel              *model;
+       GtkTreePath                *src_path;
+       GtkTreeIter                 iter;
+       GtkTreeModel               *model;
        EmpathyContact             *contact;
-       const gchar               *id;
+       McAccount                  *account;
+       const gchar                *contact_id;
+       const gchar                *account_id;
+       gchar                      *str;
+       
 
        priv = GET_PRIV (widget);
 
@@ -1006,18 +979,20 @@ contact_list_view_drag_data_get (GtkWidget        *widget,
                return;
        }
 
-       id = empathy_contact_get_id (contact);
+       account = empathy_contact_get_account (contact);
+       account_id = mc_account_get_unique_name (account);
+       contact_id = empathy_contact_get_id (contact);
        g_object_unref (contact);
+       str = g_strconcat (account_id, "/", contact_id, NULL);
 
        switch (info) {
        case DND_DRAG_TYPE_CONTACT_ID:
                gtk_selection_data_set (selection, drag_atoms_source[info], 8,
-                                       (guchar*)id, strlen (id) + 1);
+                                       (guchar*)str, strlen (str) + 1);
                break;
-
-       default:
-               return;
        }
+
+       g_free (str);
 }
 
 static void
@@ -1113,6 +1088,33 @@ contact_list_view_pixbuf_cell_data_func (GtkTreeViewColumn     *tree_column,
        contact_list_view_cell_set_background (view, cell, is_group, is_active);
 }
 
+#ifdef HAVE_VOIP
+static void
+contact_list_view_voip_cell_data_func (GtkTreeViewColumn      *tree_column,
+                                      GtkCellRenderer        *cell,
+                                      GtkTreeModel           *model,
+                                      GtkTreeIter            *iter,
+                                      EmpathyContactListView *view)
+{
+       gboolean is_group;
+       gboolean is_active;
+       gboolean can_voip;
+
+       gtk_tree_model_get (model, iter,
+                           COL_IS_GROUP, &is_group,
+                           COL_IS_ACTIVE, &is_active,
+                           COL_CAN_VOIP, &can_voip,
+                           -1);
+
+       g_object_set (cell,
+                     "visible", !is_group && can_voip,
+                     "icon-name", EMPATHY_IMAGE_VOIP,
+                     NULL);
+
+       contact_list_view_cell_set_background (view, cell, is_group, is_active);
+}
+#endif
+
 static void
 contact_list_view_avatar_cell_data_func (GtkTreeViewColumn     *tree_column,
                                         GtkCellRenderer       *cell,
@@ -1205,7 +1207,8 @@ contact_list_view_expander_cell_data_func (GtkTreeViewColumn     *column,
 static GtkWidget *
 contact_list_view_get_contact_menu (EmpathyContactListView *view,
                                    gboolean               can_send_file,
-                                   gboolean               can_show_log)
+                                   gboolean               can_show_log,
+                                   gboolean               can_voip)
 {
        EmpathyContactListViewPriv *priv;
        GtkAction                 *action;
@@ -1217,6 +1220,11 @@ contact_list_view_get_contact_menu (EmpathyContactListView *view,
        action = gtk_ui_manager_get_action (priv->ui, "/Contact/Log");
        gtk_action_set_sensitive (action, can_show_log);
 
+#ifdef HAVE_VOIP
+       action = gtk_ui_manager_get_action (priv->ui, "/Contact/Call");
+       gtk_action_set_sensitive (action, can_voip);
+#endif
+
        action = gtk_ui_manager_get_action (priv->ui, "/Contact/SendFile");
        gtk_action_set_visible (action, can_send_file);
 
@@ -1239,12 +1247,12 @@ contact_list_view_button_press_event_cb (EmpathyContactListView *view,
        gboolean                   row_exists;
        GtkWidget                 *menu;
 
-       if (event->button != 3) {
+       priv = GET_PRIV (view);
+
+       if (!priv->interactive || event->button != 3) {
                return FALSE;
        }
 
-       priv = GET_PRIV (view);
-
        selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (view));
        model = gtk_tree_view_get_model (GTK_TREE_VIEW (view));
 
@@ -1288,13 +1296,18 @@ contact_list_view_button_press_event_cb (EmpathyContactListView *view,
 
 static void
 contact_list_view_row_activated_cb (EmpathyContactListView *view,
-                                   GtkTreePath           *path,
-                                   GtkTreeViewColumn     *col,
-                                   gpointer               user_data)
+                                   GtkTreePath            *path,
+                                   GtkTreeViewColumn      *col,
+                                   gpointer                user_data)
 {
-       EmpathyContact *contact;
-       GtkTreeModel  *model;
-       GtkTreeIter    iter;
+       EmpathyContactListViewPriv *priv = GET_PRIV (view);
+       EmpathyContact             *contact;
+       GtkTreeModel               *model;
+       GtkTreeIter                 iter;
+
+       if (!priv->interactive) {
+               return;
+       }
 
        model = gtk_tree_view_get_model (GTK_TREE_VIEW (view));
 
@@ -1307,6 +1320,36 @@ contact_list_view_row_activated_cb (EmpathyContactListView *view,
        }
 }
 
+#ifdef HAVE_VOIP
+static void
+contact_list_view_voip_activated_cb (EmpathyCellRendererActivatable *cell,
+                                    const gchar                    *path_string,
+                                    EmpathyContactListView         *view)
+{
+       EmpathyContactListViewPriv *priv = GET_PRIV (view);
+       GtkTreeModel               *model;
+       GtkTreeIter                 iter;
+       EmpathyContact             *contact;
+
+       if (!priv->interactive) {
+               return;
+       }
+
+       model = gtk_tree_view_get_model (GTK_TREE_VIEW (view));
+       if (!gtk_tree_model_get_iter_from_string (model, &iter, path_string)) {
+               return;
+       }
+
+       gtk_tree_model_get (model, &iter, COL_CONTACT, &contact, -1);
+
+       if (contact) {
+               contact_list_view_voip_activated (view, contact);
+               g_object_unref (contact);
+       }
+}
+#endif
+
+
 static void
 contact_list_view_row_expand_or_collapse_cb (EmpathyContactListView *view,
                                             GtkTreeIter           *iter,
@@ -1329,124 +1372,6 @@ contact_list_view_row_expand_or_collapse_cb (EmpathyContactListView *view,
        g_free (name);
 }
 
-static gboolean 
-contact_list_view_filter_show_contact (EmpathyContact *contact,
-                                      const gchar   *filter)
-{
-       gchar    *str;
-       gboolean  visible;
-
-       /* Check contact id */
-       str = g_utf8_casefold (empathy_contact_get_id (contact), -1);
-       visible = G_STR_EMPTY (str) || strstr (str, filter);
-       g_free (str);
-
-       if (visible) {
-               return TRUE;
-       }
-
-       /* Check contact name */
-       str = g_utf8_casefold (empathy_contact_get_name (contact), -1);
-       visible = G_STR_EMPTY (str) || strstr (str, filter);
-       g_free (str);
-       
-       return visible;
-}
-
-static gboolean
-contact_list_view_filter_show_group (EmpathyContactListView *view,
-                                    const gchar           *group,
-                                    const gchar           *filter)
-{
-       EmpathyContactListViewPriv *priv;
-       EmpathyContactList        *list;
-       GList                     *contacts, *l;
-       gchar                     *str;
-       gboolean                   show_group = FALSE;
-
-       priv = GET_PRIV (view);
-       
-       str = g_utf8_casefold (group, -1);
-       if (!str) {
-               return FALSE;
-       }
-
-       /* If the filter is the partially the group name, we show the
-        * whole group.
-        */
-       if (strstr (str, filter)) {
-               g_free (str);
-               return TRUE;
-       }
-
-       /* At this point, we need to check in advance if this
-        * group should be shown because a contact we want to
-        * show exists in it.
-        */
-       list = empathy_contact_list_store_get_list_iface (priv->store);
-       contacts = empathy_contact_list_get_members (list);
-       for (l = contacts; l && !show_group; l = l->next) {
-               if (!empathy_contact_is_in_group (l->data, group)) {
-                       g_object_unref (l->data);
-                       continue;
-               }
-
-               if (contact_list_view_filter_show_contact (l->data, filter)) {
-                       show_group = TRUE;
-               }
-               g_object_unref (l->data);
-       }
-       g_list_free (contacts);
-       g_free (str);
-
-       return show_group;
-}
-
-static gboolean
-contact_list_view_filter_func (GtkTreeModel          *model,
-                              GtkTreeIter           *iter,
-                              EmpathyContactListView *view)
-{
-       EmpathyContactListViewPriv *priv;
-       gboolean                   is_group;
-       gboolean                   is_separator;
-       gboolean                   visible = TRUE;
-
-       priv = GET_PRIV (view);
-
-       if (G_STR_EMPTY (priv->filter_text)) {
-               return TRUE;
-       }
-       
-       /* Check to see if iter matches any group names */
-       gtk_tree_model_get (model, iter,
-                           COL_IS_GROUP, &is_group,
-                           COL_IS_SEPARATOR, &is_separator,
-                           -1);
-
-       if (is_group) {
-               gchar *name;
-
-               gtk_tree_model_get (model, iter, COL_NAME, &name, -1);
-               visible &= contact_list_view_filter_show_group (view,
-                                                               name,
-                                                               priv->filter_text);
-               g_free (name);
-       } else if (is_separator) {
-               /* Do nothing here */
-       } else {
-               EmpathyContact *contact;
-
-               /* Check contact id */
-               gtk_tree_model_get (model, iter, COL_CONTACT, &contact, -1);
-               visible &= contact_list_view_filter_show_contact (contact, 
-                                                                 priv->filter_text);
-               g_object_unref (contact);
-       }
-
-       return visible;
-}
-
 static void
 contact_list_view_action_cb (GtkAction             *action,
                             EmpathyContactListView *view)
@@ -1473,11 +1398,14 @@ contact_list_view_action_cb (GtkAction             *action,
        if (contact && strcmp (name, "Chat") == 0) {
                contact_list_view_action_activated (view, contact);
        }
+       else if (contact && strcmp (name, "Call") == 0) {
+               contact_list_view_voip_activated (view, contact);
+       }
        else if (contact && strcmp (name, "Information") == 0) {
-               empathy_contact_information_dialog_show (contact, parent, FALSE);
+               empathy_contact_information_dialog_show (contact, parent, FALSE, FALSE);
        }
        else if (contact && strcmp (name, "Edit") == 0) {
-               empathy_contact_information_dialog_show (contact, parent, TRUE);
+               empathy_contact_information_dialog_show (contact, parent, TRUE, TRUE);
        }
        else if (contact && strcmp (name, "Remove") == 0) {
                /* FIXME: Ask for confirmation */
@@ -1522,3 +1450,10 @@ contact_list_view_action_activated (EmpathyContactListView *view,
        g_object_unref (mc);
 }
 
+static void
+contact_list_view_voip_activated (EmpathyContactListView *view,
+                                 EmpathyContact         *contact)
+{
+       empathy_call_contact (contact);
+}
+