From ff897a9a71c4eb91548f40ab6ea09e17936cd8c1 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 11 Sep 2013 16:24:42 +0200 Subject: [PATCH] menu_removed_cb: call g_menu_model_get_n_items() once No need to call it during each iteration. https://bugzilla.gnome.org/show_bug.cgi?id=707885 --- src/empathy-roster-window.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/empathy-roster-window.c b/src/empathy-roster-window.c index 018e2200..9dd7a4e7 100644 --- a/src/empathy-roster-window.c +++ b/src/empathy-roster-window.c @@ -1354,10 +1354,11 @@ roster_window_favorite_chatroom_menu_removed_cb ( EmpathyRosterWindow *self) { GList *chatrooms; - gint i; + guint i, n; - for (i = 0; i < g_menu_model_get_n_items ( - G_MENU_MODEL (self->priv->rooms_section)); i++) + n = g_menu_model_get_n_items (G_MENU_MODEL (self->priv->rooms_section)); + + for (i = 0; i < n; i++) { const gchar *name; -- 2.39.2