From ddae3ae13b1bf6368bd91327357e3c6999ac6a45 Mon Sep 17 00:00:00 2001 From: Lars-Peter Clausen Date: Fri, 17 Apr 2009 23:00:10 +0200 Subject: [PATCH] Fix memleak in log_store_empathy_get_chats_for_dir. Only build filename if its needed and freed again. --- libempathy/empathy-log-store-empathy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libempathy/empathy-log-store-empathy.c b/libempathy/empathy-log-store-empathy.c index 11e64e0e..37a76676 100644 --- a/libempathy/empathy-log-store-empathy.c +++ b/libempathy/empathy-log-store-empathy.c @@ -641,17 +641,15 @@ log_store_empathy_get_chats_for_dir (EmpathyLogStore *self, while ((name = g_dir_read_name (gdir)) != NULL) { EmpathyLogSearchHit *hit; - gchar *filename; - filename = g_build_filename (dir, name, NULL); if (!is_chatroom && strcmp (name, LOG_DIR_CHATROOMS) == 0) { + gchar *filename = g_build_filename (dir, name, NULL); hits = g_list_concat (hits, log_store_empathy_get_chats_for_dir ( self, filename, TRUE)); g_free (filename); continue; } - hit = g_slice_new0 (EmpathyLogSearchHit); hit->chat_id = g_strdup (name); hit->is_chatroom = is_chatroom; -- 2.39.2