Will Thompson [Fri, 24 Jun 2011 10:44:35 +0000 (11:44 +0100)]
PresetDialog: make status icon in entry non-activatable
It's not meaningfully activatable; this has the effect of making it not
glow on mouse-over, and preventing the cursor from changing from a caret
back to a pointer.
Will Thompson [Fri, 10 Jun 2011 20:09:33 +0000 (21:09 +0100)]
PresetDialog: Select text cell of freshly-added status
This means you can just mash Enter to edit your mistake. It's more
useful than leaving the text entry focused. It also helps hide a bug
where the entry doesn't get cleared if you just start typing another
message. So previously, typing:
Hello<Enter>Miaow<Enter>
would give you two statuses, "Hello" and "MiaowEnter Custom Message".
It didn't seem worth fixing this much more since Gtk+ 3.2 will probably
grow native support for placeholder text:
<https://bugzilla.gnome.org/show_bug.cgi?id=440963>
Will Thompson [Fri, 10 Jun 2011 19:07:35 +0000 (20:07 +0100)]
PresetDialog: make the window taller
The element we really care about the size of is the list of statuses
past. So I moved the horizontal size request to that—the window has 6px
of padding or so, so this makes it pretty much exactly the same
width—and made the height request be in the golden ratio to it.
I'm probably unusual in having enough statuses to fill my laptop screen
vertically, but, subjectively, this makes the dialog look less stubby
even now I've removed them all to test.
EmpathyCallWindow and EmpathyStreamedMediaWindow were sharing
the same .ui file, but they weren't both implementing everything
(right now StreamedMedia didn't handle the Dialpad menu item).
So add a empathy-streamed-media-window.ui from before new stuff
was added to empathy-call-window.ui.
Don't try to access empathy_adium_info_* stuff when webkit support is disabled
empathy-preferences.c:(.text+0x5dc): undefined reference to `empathy_adium_info_get_available_variants'
empathy-preferences.c:(.text+0x5e9): undefined reference to `empathy_adium_info_get_default_variant'
call-observer: use tp_channel_dispatch_operation_leave_channels_async() (#651473)
We now return from Observe() right after having called Claim(). That's what
the spec suggests and not doing so would break Claim() which can't return
while Observer didn't return from Observe.
LogWindow: allow to start actions from an event row
If we don't know the contact by looking at the 'Who' pane (because
e.g. there are many selected or it has 'Anyone'), look at the
selected row (if any) in the events pane to determine the contact.
Danielle Madeley [Fri, 20 May 2011 05:25:58 +0000 (15:25 +1000)]
Get the original message from the logger so we can supersede it
Strictly, we don't need to do this, we could just use the supersedes-token
as the message-token and we'd still be able to edit the messages in the future,
but this way we get the nice pretty annotation saying that we edited it and
when.
Danielle Madeley [Fri, 20 May 2011 03:02:45 +0000 (13:02 +1000)]
Add an icon to edited messages
Currently this is using "format-text-direction-ltr" which is a crappy choice.
We should ask for a better icon. Also, this should really be implemented as
a class, so that the icon can change with the theme. Or be made part of the
Adium theme, or something. Basically this is kludgey.
Danielle Madeley [Wed, 18 May 2011 06:04:26 +0000 (16:04 +1000)]
[theme-adium] implement edit_message()
This is done via DOM manipulation, we find the id for the <span> tag we
wrapped the message in in the previous commit. We then replace the innerHTML
with the new message.
This requires a version of WebKitGtk 1.3.x, but I'm not precisely sure what. I
used WebKitGtk 1.4.0, but natty only has 1.3.13, so we'll try setting that as
the dep.
Need to somehow mark a message as edited. Could set a class on it, but that
requires support in the theme. Need inspiration here.
Danielle Madeley [Fri, 20 May 2011 01:34:31 +0000 (11:34 +1000)]
Add 'supersedes' property to EmpathyMessage
It would be nice to remove EmpathyMessage, because now that TpMessages are a
GObject, EmpathyMessage is just an empty abstraction layer that we have to
keep punching through.
Rationalize use of EMPATHY_IMAGE_CALL_* images (#652270)
We now always use call-start for incoming and outgoing calls and call-stop for
missed ones. Ideally it would be cool to have different icons for incoming and
outgoing but that will do for now.