Jonathan Tellier [Fri, 28 Aug 2009 18:19:47 +0000 (14:19 -0400)]
Fixed bug which would occur when deleting account with pending changes
- When the selected account was NULL,
accounts_dialog_has_pending_change() would not check its state
correctly. That function is working with a pointer on a pointer to the
account and was not dereferencing properly.
- The pointer to the account we pass to
accounts_dialog_has_pending_change() is now properly initialized to
NULL.
- When deleting an account, the COL_ACCOUNT_POINTER column is now
properly set to NULL.
Jonathan Tellier [Fri, 28 Aug 2009 15:23:44 +0000 (11:23 -0400)]
Using GtkTreeRowReference instead of a string path.
- When the user selects another account and has pending changes to the
currently selected account, we need to keed track of the destination
row. Instead of saving that information as the string representation
of a GtkTreePath, we now use a GtkTreeRowReference.
Jonathan Tellier [Fri, 28 Aug 2009 14:45:54 +0000 (10:45 -0400)]
Improved confirmation dialog shown to the user before discarding changes
- Split the confirmation dialog's text into a primary and secondary
section.
- Changed the button label to "Cancel" and "Discard" instead of "Yes"
and "No".
- Added a accounts_dialog_show_question_dialog() function to show
question dialogs related to the accounts dialog and connect to its
"response" signal.
- Removed the empathy_show_yes_no_question_dialog() function since it
was added for this specific patch but is no longer used.
Jonathan Tellier [Thu, 27 Aug 2009 15:57:18 +0000 (11:57 -0400)]
Minor changes to EmpathyAccountWidget and EmpathyAccountsDialog
- account_widget_entry_changed_common is not called when an entry loses
focus. Since this function is called on every keystroke, it was
unnecessary to call it again on focus-out-event.
- The EmpathyAccountWidget's control buttons' sensitivity (and
contains_pending_changes member) is not altered when the state of the
"Enabled" checkbox is changed due to an event which was not initiated
by the user.
- Fixed capitalization error in a comment in empathy-accounts-dialog.c
Jonathan Tellier [Wed, 26 Aug 2009 16:52:45 +0000 (12:52 -0400)]
Asking for confirmation before losing pending accounts changes.
If an account has pending changes, we now ask for a confirmation before:
- Adding a new account
- Closing the accounts dialog
- Selecting a new account.
Those are all options which discard pending changes.
Sjoerd Simons [Thu, 27 Aug 2009 15:56:42 +0000 (16:56 +0100)]
Base the selected widget both on the CM and the protocol
Previously Empathy would select the custom account widget purely based on the
protocol, the problem here is that these widgets assume one specific connection
manager and its set of parameters. Which triggered bugs if the intended cm for a
protocol isn't installed, but haze is and provides the protocol.
Milo Casagrande [Thu, 27 Aug 2009 22:00:31 +0000 (00:00 +0200)]
[help] Fixed some topics against the new UI
Topics fixed: add-account, disable-account, remove-account, irc-account
Added irc-account to irc-manage
Used 2column for irc-manage
Will Thompson [Wed, 26 Aug 2009 18:47:49 +0000 (19:47 +0100)]
Don't parse message in EmpathyMessage:body setter
This fixes a bug where the message (Type_Action, "/me wooo yay") is
printed as " ! wjt woo yay" rather than as " ! wjt /me woo yay".
This also fixes Gnome bug #593101 (Empathy exits sending empty /me
message), which was caused by this deleted code walking off the end of
the string "/me".
Will Thompson [Wed, 26 Aug 2009 18:46:39 +0000 (19:46 +0100)]
Add empathy_message_new_from_entry()
This will be the sole place that user input is parsed for special
commands like /me; the parsing logic will be removed from EmpathyMessage
and chat_send().
Sjoerd Simons [Thu, 27 Aug 2009 17:29:51 +0000 (18:29 +0100)]
When not connected don't apply !offline states but save them
When we're not connected to a network don't allow setting the status to
anything else then offline, but when a status is set do save it so it can be
applied as soon as soon as we get network connectivity
Jonathan Tellier [Wed, 26 Aug 2009 19:37:39 +0000 (15:37 -0400)]
Using a new logic to set the default display name:
* If irc use "[account] on [server]"
* If there is an account property use "[account]"
* If there is no account property use "[protocol] Account"
Jonathan Tellier [Tue, 25 Aug 2009 17:18:56 +0000 (13:18 -0400)]
- The account display gets updated in the account list and in the
account name label.
- By default, the account default display name is set to the login id.
Cosimo Cecchi [Wed, 26 Aug 2009 11:00:24 +0000 (13:00 +0200)]
Ensure all accounts when getting all properties
This introduces a check on the number of accounts, as MC5 could come
back advertising less accounts than we have. In that case, we find the
one which have gone and remove them from our cache.
Jonathan Tellier [Tue, 25 Aug 2009 19:57:41 +0000 (15:57 -0400)]
- Added a utility function (empathy_account_reconnect_async) to easily
reconnect an account.
- When we apply changes to an account, instead of disconnecting and
reconnecting it, we use the new empathy_account_reconnect_async
function.
Xavier Claessens [Fri, 21 Aug 2009 12:39:03 +0000 (14:39 +0200)]
Make EmpathyDebugDialog be a GtkWindow subclass rather than a GtkDialog.
This is because:
1) There are no actions, so it's not a dialog
2) We want to hide the seperator for the action area
3) To be able to maximize the window
Will Thompson [Tue, 25 Aug 2009 13:37:57 +0000 (14:37 +0100)]
Add human-readable names for Yahoo! Japan and Facebook Chat
These are both marked for translation. Obviously the first should be
localized in its target market, and the latter probably wants
translating too (perhaps "Clavardage de Facebook"?).
projects / empathy.git / log