accounts-dialog: update the status info when account when account is enabled
If we are offline and we enable a disabled account, the info bar message
should be updated from "Acconut Disabled" to "Status is set to Offline"
(#610847).
Cosimo Alfarano [Fri, 26 Feb 2010 13:52:36 +0000 (13:52 +0000)]
Update to TPL 0.1.1
Updated the the pkg-config version to 0.1.1
Updated the the pkg-config dep name fom libtelepathy-logger to telepathy-logger
Updated TPL's _finish() methods using one for each async API.
contact-widget: display map even if contact only published his lat/lon
We used to hide the whole location vbox if no field was displayed in the
location table (such as street, city, etc).
But if contact only publishes it's lat and lon, we can at least display the
map widget. (#611062)
With the move to the ChannelDispatcher channels we've requested will either not
be dispatched through HandleChannels (because we used the old way of directly
requesting it on the MC) or will get passed after we've started the request and
can thus be dispatched right away. The concept of oustanding channel is thus
obsolete.
Before moving to the ChannelDispatcher we got channels either through the
NewChannel(s) signal or as a result of requesting a channel from the CM. Now
that we've moved to the ChannelDispatcher, we only get channels that we should
handle through HandleChannels. So we shouldn't filter any of them.
assistant: Fix creation of the last account created
When user enters the details about his last account, the 'prepare' signal is
not fired. So we should create the account in impl_signal_apply instead.
Fixes bug #609995.
Don't display the 'respond' button in presence notifications (#610032)
This button doesn't make anything as this event is not activatable. Plan is to
display better button at some point (see bug 597124) but for now let's remove
this button when it's useless.
Milo Casagrande [Tue, 16 Feb 2010 17:38:00 +0000 (18:38 +0100)]
[help] Fixed the Apply button on account creation
* Added a small section about proxy configuration
* Updated the errors topics
* Fixed a capitalization glitch, at least now titles are all the same
dispatcher_connection_new_requested_channel: fix a use-after-free crash
If an error occurs when requesting the channel, we call
dispatcher_request_failed which as the side effect of destroying the
DispatcherRequestData. When calling dispatcher_flush_outstanding_operations
we used to deference this pointer.
Fixes this crash by using the "self" pointer instead and reffing it to be sure
it stays valid.
accounts-dialog: block the selection 'changed' signal while removing a row
There is no need to call accounts_dialog_model_selection_changed while removing
as we are going to call accounts_dialog_model_select_first right after which
will update the selection.
This has the nice side effect of letting the "remove" button sensitive after
the account has been removed. The callback used to be called recursively twice:
once during the removal of the row and once when calling
accounts_dialog_model_select_first in accounts_dialog_update_settings.
As accounts_dialog_model_selection_changed is checking if a row is selected
*before* calling accounts_dialog_update_settings, the button was unsensitived
at the end of the first call of the callback. (#609575)
Sjoerd Simons [Mon, 15 Feb 2010 12:05:09 +0000 (12:05 +0000)]
Make the ChatWindow handle dropping items itself
Both GtkNotebook and EmpathChatWindow take action when drag-data-received is
signalled (moving the tab or adding a contact). Drag data is received after the
program has asked for it, usually when a drop occurs. Now this can be done in
two ways 0) Handle the drop signal yourself and call gtk_drag_get_data yourself
or 1) set GTK_DEST_DEFAULT_DROP and let gtk call it for you.
GtkNotebook takes option 0, EmpathyChatWindow decided to use option 1.. This
causes all kind of strange issues as the drag data is now requested twice and
thus the signal handlers are called twice causing all kinds of fun issues
(trying to move a tab that's already moved etc).
Change the drag dest flags to GTK_DEST_DEFAULT_HIGHLIGHT which provides some
extra visual clues but is other harmless and handle drops directly. Also remove
some cases where ChatWindow meddles with tab dragging as GtkNotebook will
handle these for us