From: Xavier Claessens <xclaesse@gmail.com>
Date: Thu, 26 Nov 2009 09:16:39 +0000 (+0100)
Subject: Clean how we insert link in adium themes
X-Git-Url: https://git.0d.be/?p=empathy.git;a=commitdiff_plain;h=02ca446606c2c9f2673188b811891dd107c21e19

Clean how we insert link in adium themes
---

diff --git a/libempathy-gtk/empathy-theme-adium.c b/libempathy-gtk/empathy-theme-adium.c
index 2e88ec1d..f1979a6c 100644
--- a/libempathy-gtk/empathy-theme-adium.c
+++ b/libempathy-gtk/empathy-theme-adium.c
@@ -228,22 +228,20 @@ theme_adium_replace_link (const gchar *text,
 {
 	GString *string = user_data;
 	gchar *real_url;
-	gchar *str;
+	gchar *escaped;
 
-	/* Append the link inside <a href=""></a> tag */
 	real_url = empathy_make_absolute_url_len (text, len);
 
-	g_string_append_printf (string, "<a href=\"%s\">", real_url);
-
 	/* The thing we are making a link of may contain
 	 * characters which need escaping */
-	str = g_markup_escape_text (text, len);
-	g_string_append (string, str);
-	g_free (str);
+	escaped = g_markup_escape_text (text, len);
 
-	g_string_append (string, "</a>");
+	/* Append the link inside <a href=""></a> tag */
+	g_string_append_printf (string, "<a href=\"%s\">%s</a>",
+				real_url, escaped);
 
 	g_free (real_url);
+	g_free (escaped);
 }
 
 static gboolean use_smileys = FALSE;