]> git.0d.be Git - empathy.git/commitdiff
Removed leak with g_string_free, added comment for 0xFFFC
authorGabriel Millaire <millaire.gabriel@gmail.com>
Tue, 6 Oct 2009 08:24:52 +0000 (10:24 +0200)
committerXavier Claessens <xclaesse@gmail.com>
Tue, 6 Oct 2009 08:29:31 +0000 (10:29 +0200)
libempathy-gtk/empathy-chat-text-view.c

index 5b0a3568055c31a165418de0e86b79f35a123c98..aacc847db54d49aa152a84a4597effc30072970c 100644 (file)
@@ -1180,6 +1180,8 @@ chat_text_view_copy_clipboard (EmpathyChatView *view)
 
        for (iter = start; !gtk_text_iter_equal (&iter, &end); gtk_text_iter_forward_char (&iter)) {
                c = gtk_text_iter_get_char (&iter);
+               /* 0xFFFC is the 'object replacement' unicode character,
+                * it indicates the presence of a pixbuf or a widget. */
                if (c == 0xFFFC) {
                        ignore_newlines = FALSE;
                        if ((pixbuf = gtk_text_iter_get_pixbuf (&iter))) {
@@ -1210,7 +1212,8 @@ chat_text_view_copy_clipboard (EmpathyChatView *view)
                }
        }
 
-       gtk_clipboard_set_text (clipboard, g_string_free (str, FALSE), str->len);
+       gtk_clipboard_set_text (clipboard, str->str, str->len);
+       g_string_free (str, TRUE)
 }
 
 static void