]> git.0d.be Git - empathy.git/commitdiff
tp_contact_list_remove: add FIXME about potential race
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Wed, 9 Dec 2009 16:15:09 +0000 (16:15 +0000)
committerGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Wed, 9 Dec 2009 16:15:09 +0000 (16:15 +0000)
libempathy/empathy-tp-contact-list.c

index 9ef71b4f9b9e4a165b20bfb7441b1d9760109e59..9b67ec7e25f599d6b26d833b9dc5099c0fa79f0f 100644 (file)
@@ -1060,6 +1060,8 @@ tp_contact_list_remove (EmpathyContactList *list,
 
        handle = empathy_contact_get_handle (contact);
 
+       /* FIXME: this is racy if tp_contact_list_remove is called before the
+        * 'stored' list has been retrieved. */
        if (priv->stored != NULL) {
                tp_cli_channel_interface_group_call_remove_members (priv->stored,
                        -1, &handles, message, NULL, NULL, NULL, NULL);