]> git.0d.be Git - empathy.git/commitdiff
Correct Call channel refcounting
authorSjoerd Simons <sjoerd.simons@collabora.co.uk>
Thu, 17 Mar 2011 11:29:38 +0000 (11:29 +0000)
committerEmilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Thu, 9 Jun 2011 09:20:07 +0000 (10:20 +0100)
The Call channel will get unreffed by the destroy function that's given
to empathy_tp_contact_factory_get_from_id. So don't unref it in the
callback explicitely

src/empathy-call-factory.c

index 9ee4a9567030ad8c672c78e0ac3c12ae761d82f3..135e4e238ba383198019bb1b95b796c87d7993e6 100644 (file)
@@ -274,7 +274,7 @@ call_channel_got_contact (TpConnection *connection,
     {
       /* FIXME use hangup with an appropriate error */
       tp_channel_close_async (TP_CHANNEL (call), NULL, NULL);
-      goto out;
+      return;
     }
 
   handler = empathy_call_handler_new_for_channel (call, contact);
@@ -283,9 +283,6 @@ call_channel_got_contact (TpConnection *connection,
     handler, FALSE);
 
   g_object_unref (handler);
-
-out:
-  g_object_unref (call);
 }