]> git.0d.be Git - empathy.git/commitdiff
moving retrieving_backlog = FALSE right before empathy_chat_messages_read()
authorCosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Thu, 25 Feb 2010 19:15:15 +0000 (19:15 +0000)
committerCosimo Alfarano <cosimo.alfarano@collabora.co.uk>
Thu, 25 Feb 2010 19:15:15 +0000 (19:15 +0000)
or it will allow race conditions

libempathy-gtk/empathy-chat.c

index 2c563c665005f2f4133619732807dfc33f5bf049..edb2aabc36abd89731ad0c51b9636914afb65b28 100644 (file)
@@ -1838,13 +1838,13 @@ got_filtered_messages_cb (GObject *manager,
        g_list_free (messages);
 
 out:
-       priv->retrieving_backlogs = FALSE;
        /* in case of TPL error, skip backlog and show pending messages */
        priv->can_show_pending = TRUE;
        show_pending_messages (chat);
 
        /* FIXME: See Bug#610994, we are forcing the ACK of the queue. See comments
         * about it in EmpathyChatPriv definition */
+       priv->retrieving_backlogs = FALSE;
        empathy_chat_messages_read (chat);
 
        /* Turn back on scrolling */