]> git.0d.be Git - empathy.git/commitdiff
Fix a logic error when expanding groups in EmpathyIndividualView
authorPhilip Withnall <philip.withnall@collabora.co.uk>
Mon, 30 Aug 2010 09:58:40 +0000 (10:58 +0100)
committerPhilip Withnall <philip.withnall@collabora.co.uk>
Mon, 30 Aug 2010 11:03:06 +0000 (12:03 +0100)
This prevents use of uninitialised memory in the second part of the
expression, and should cause groups to be added to the table of groups to
expand/contract more frequently (correctly). Helps: bgo#628106

libempathy-gtk/empathy-individual-view.c

index cffb5c99a914d1718cae0ba44d6780bd3746f718..1c8dd21cf66587b77573aa4c3fb0713c344e18d4 100644 (file)
@@ -1512,7 +1512,7 @@ individual_view_row_has_child_toggled_cb (GtkTreeModel *model,
    * a hash table, and expand or contract them as appropriate all at once in
    * an idle handler which iterates over all the group rows. */
   if (g_hash_table_lookup_extended (priv->expand_groups, name, NULL,
-      &will_expand) == FALSE &&
+      &will_expand) == FALSE ||
       GPOINTER_TO_INT (will_expand) != should_expand)
     {
       g_hash_table_insert (priv->expand_groups, g_strdup (name),