]> git.0d.be Git - empathy.git/commit
Include SMSChannel property in empathy_chat_window_find_chat()
authorDanielle Madeley <danielle.madeley@collabora.co.uk>
Thu, 5 May 2011 06:22:23 +0000 (16:22 +1000)
committerDanielle Madeley <danielle.madeley@collabora.co.uk>
Thu, 5 May 2011 06:31:51 +0000 (16:31 +1000)
commit0fda59487b536e49bfcec7ab1ee6e9c6d7b6f306
treec742771832d409e1acf3c37236c0d2a84dcada8c
parent11e8ca993282f16043b821f00e55f5ebd03fb089
Include SMSChannel property in empathy_chat_window_find_chat()

The approach in https://bugzilla.gnome.org/show_bug.cgi?id=644085 was wrong
because channel paths can change across reconnects. This would cause new chat
windows to be created when they were rerequested.

A more future-proof solution would be to keep a white/black list of comparable
properties, but I think this is overengineering the problem for the time
being. Instead we'll just include the SMSChannel property in the comparison.
src/empathy-chat-manager.c
src/empathy-chat-window.c
src/empathy-chat-window.h