X-Git-Url: https://git.0d.be/?p=empathy.git;a=blobdiff_plain;f=libempathy-gtk%2Fempathy-individual-view.c;h=90618997d36e1295c2f388681b341a235fd24315;hp=fcbc93fa47ab69221f7f7030ac27ac84217ecb91;hb=6048958136681930af236460e9cb159b5267c4d0;hpb=c84e0979d36aa41e7f0d554fbbdad4e82756f8b0 diff --git a/libempathy-gtk/empathy-individual-view.c b/libempathy-gtk/empathy-individual-view.c index fcbc93fa..90618997 100644 --- a/libempathy-gtk/empathy-individual-view.c +++ b/libempathy-gtk/empathy-individual-view.c @@ -46,7 +46,7 @@ #include "empathy-individual-view.h" #include "empathy-individual-menu.h" #include "empathy-individual-store.h" -#include "empathy-contact-dialogs.h" +#include "empathy-individual-edit-dialog.h" #include "empathy-individual-dialogs.h" #include "empathy-images.h" #include "empathy-linking-dialog.h" @@ -55,7 +55,6 @@ #include "empathy-cell-renderer-activatable.h" #include "empathy-ui-utils.h" #include "empathy-gtk-enum-types.h" -#include "empathy-gtk-marshal.h" #define DEBUG_FLAG EMPATHY_DEBUG_CONTACT #include @@ -75,6 +74,7 @@ typedef struct gboolean show_offline; gboolean show_untrusted; + gboolean show_uninteresting; GtkTreeModelFilter *filter; GtkWidget *search_widget; @@ -88,6 +88,9 @@ typedef struct /* Distance between mouse pointer and the nearby border. Negative when scrolling updards.*/ gint distance; + + GtkTreeModelFilterVisibleFunc custom_filter; + gpointer custom_filter_data; } EmpathyIndividualViewPriv; typedef struct @@ -112,6 +115,7 @@ enum PROP_INDIVIDUAL_FEATURES, PROP_SHOW_OFFLINE, PROP_SHOW_UNTRUSTED, + PROP_SHOW_UNINTERESTING, }; /* TODO: re-add DRAG_TYPE_CONTACT_ID, for the case that we're dragging around @@ -129,8 +133,8 @@ typedef enum { (gchar *) T, 0, I } static const GtkTargetEntry drag_types_dest[] = { - DRAG_TYPE ("text/individual-id", DND_DRAG_TYPE_INDIVIDUAL_ID), - DRAG_TYPE ("text/persona-id", DND_DRAG_TYPE_PERSONA_ID), + DRAG_TYPE ("text/x-individual-id", DND_DRAG_TYPE_INDIVIDUAL_ID), + DRAG_TYPE ("text/x-persona-id", DND_DRAG_TYPE_PERSONA_ID), DRAG_TYPE ("text/path-list", DND_DRAG_TYPE_URI_LIST), DRAG_TYPE ("text/uri-list", DND_DRAG_TYPE_URI_LIST), DRAG_TYPE ("text/plain", DND_DRAG_TYPE_STRING), @@ -138,7 +142,7 @@ static const GtkTargetEntry drag_types_dest[] = { }; static const GtkTargetEntry drag_types_source[] = { - DRAG_TYPE ("text/individual-id", DND_DRAG_TYPE_INDIVIDUAL_ID), + DRAG_TYPE ("text/x-individual-id", DND_DRAG_TYPE_INDIVIDUAL_ID), }; #undef DRAG_TYPE @@ -215,8 +219,10 @@ individual_view_query_tooltip_cb (EmpathyIndividualView *view, EMPATHY_INDIVIDUAL_WIDGET_SHOW_CLIENT_TYPES); gtk_container_set_border_width (GTK_CONTAINER (priv->tooltip_widget), 8); g_object_ref (priv->tooltip_widget); - g_signal_connect (priv->tooltip_widget, "destroy", - G_CALLBACK (individual_view_tooltip_destroy_cb), view); + + tp_g_signal_connect_object (priv->tooltip_widget, "destroy", + G_CALLBACK (individual_view_tooltip_destroy_cb), view, 0); + gtk_widget_show (priv->tooltip_widget); } else @@ -414,6 +420,7 @@ individual_view_persona_drag_received (GtkWidget *self, FolksPersona *persona = NULL; const gchar *persona_uid; GList *individuals, *l; + GeeIterator *iter = NULL; gboolean retval = FALSE; persona_uid = (const gchar *) gtk_selection_data_get_data (selection); @@ -425,23 +432,28 @@ individual_view_persona_drag_received (GtkWidget *self, for (l = individuals; l != NULL; l = l->next) { - GList *personas, *p; + GeeSet *personas; personas = folks_individual_get_personas (FOLKS_INDIVIDUAL (l->data)); - - for (p = personas; p != NULL; p = p->next) + iter = gee_iterable_iterator (GEE_ITERABLE (personas)); + while (gee_iterator_next (iter)) { - if (!tp_strdiff (folks_persona_get_uid (FOLKS_PERSONA (p->data)), - persona_uid)) + FolksPersona *persona_cur = gee_iterator_get (iter); + + if (!tp_strdiff (folks_persona_get_uid (persona), persona_uid)) { - persona = g_object_ref (p->data); + /* takes ownership of the ref */ + persona = persona_cur; individual = g_object_ref (l->data); goto got_persona; } + g_clear_object (&persona_cur); } + g_clear_object (&iter); } got_persona: + g_clear_object (&iter); g_list_free (individuals); if (persona == NULL || individual == NULL) @@ -683,7 +695,8 @@ individual_view_drag_motion (GtkWidget *widget, EmpathyContact *contact = NULL; contact = empathy_contact_dup_from_folks_individual (individual); - caps = empathy_contact_get_capabilities (contact); + if (contact != NULL) + caps = empathy_contact_get_capabilities (contact); tp_clear_object (&contact); } @@ -802,13 +815,13 @@ individual_view_drag_begin (GtkWidget *widget, priv = GET_PRIV (widget); - GTK_WIDGET_CLASS (empathy_individual_view_parent_class)->drag_begin (widget, - context); - selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (widget)); if (!gtk_tree_selection_get_selected (selection, &model, &iter)) return; + GTK_WIDGET_CLASS (empathy_individual_view_parent_class)->drag_begin (widget, + context); + path = gtk_tree_model_get_path (model, &iter); priv->drag_row = gtk_tree_row_reference_new (model, path); gtk_tree_path_free (path); @@ -856,7 +869,7 @@ individual_view_drag_data_get (GtkWidget *widget, if (info == DND_DRAG_TYPE_INDIVIDUAL_ID) { gtk_selection_data_set (selection, - gdk_atom_intern ("text/individual-id", FALSE), 8, + gdk_atom_intern ("text/x-individual-id", FALSE), 8, (guchar *) individual_id, strlen (individual_id) + 1); } @@ -879,6 +892,12 @@ individual_view_drag_end (GtkWidget *widget, gtk_tree_row_reference_free (priv->drag_row); priv->drag_row = NULL; } + + if (priv->auto_scroll_timeout_id != 0) + { + g_source_remove (priv->auto_scroll_timeout_id); + priv->auto_scroll_timeout_id = 0; + } } static gboolean @@ -977,7 +996,6 @@ individual_view_key_press_event_cb (EmpathyIndividualView *view, g_idle_add (individual_view_popup_menu_idle_cb, data); } else if (event->keyval == GDK_KEY_F2) { FolksIndividual *individual; - EmpathyContact *contact; g_return_val_if_fail (EMPATHY_IS_INDIVIDUAL_VIEW (view), FALSE); @@ -985,15 +1003,9 @@ individual_view_key_press_event_cb (EmpathyIndividualView *view, if (individual == NULL) return FALSE; - contact = empathy_contact_dup_from_folks_individual (individual); - if (contact == NULL) { - g_object_unref (individual); - return FALSE; - } - empathy_contact_edit_dialog_show (contact, NULL); + empathy_individual_edit_dialog_show (individual, NULL); g_object_unref (individual); - g_object_unref (contact); } return FALSE; @@ -1069,12 +1081,12 @@ individual_view_call_activated_cb (EmpathyCellRendererActivatable *cell, shell = GTK_MENU_SHELL (menu); /* audio */ - item = empathy_individual_audio_call_menu_item_new (individual, NULL); + item = empathy_individual_audio_call_menu_item_new (individual); gtk_menu_shell_append (shell, item); gtk_widget_show (item); /* video */ - item = empathy_individual_video_call_menu_item_new (individual, NULL); + item = empathy_individual_video_call_menu_item_new (individual); gtk_menu_shell_append (shell, item); gtk_widget_show (item); @@ -1406,21 +1418,15 @@ individual_view_search_key_navigation_cb (GtkWidget *search, GdkEvent *event, EmpathyIndividualView *view) { - GdkEventKey *eventkey = ((GdkEventKey *) event); + GdkEvent *new_event; gboolean ret = FALSE; - if (eventkey->keyval == GDK_KEY_Up || eventkey->keyval == GDK_KEY_Down - || eventkey->keyval == GDK_KEY_F2) - { - GdkEvent *new_event; - - new_event = gdk_event_copy (event); - gtk_widget_grab_focus (GTK_WIDGET (view)); - ret = gtk_widget_event (GTK_WIDGET (view), new_event); - gtk_widget_grab_focus (search); + new_event = gdk_event_copy (event); + gtk_widget_grab_focus (GTK_WIDGET (view)); + ret = gtk_widget_event (GTK_WIDGET (view), new_event); + gtk_widget_grab_focus (search); - gdk_event_free (new_event); - } + gdk_event_free (new_event); return ret; } @@ -1529,7 +1535,7 @@ expand_idle_foreach_cb (GtkTreeModel *model, EMPATHY_INDIVIDUAL_STORE_COL_NAME, &name, -1); - if (is_group == FALSE) + if (!is_group) { g_free (name); return FALSE; @@ -1538,9 +1544,9 @@ expand_idle_foreach_cb (GtkTreeModel *model, priv = GET_PRIV (self); if (g_hash_table_lookup_extended (priv->expand_groups, name, NULL, - &should_expand) == TRUE) + &should_expand)) { - if (GPOINTER_TO_INT (should_expand) == TRUE) + if (GPOINTER_TO_INT (should_expand)) gtk_tree_view_expand_row (GTK_TREE_VIEW (self), path, FALSE); else gtk_tree_view_collapse_row (GTK_TREE_VIEW (self), path); @@ -1619,8 +1625,8 @@ individual_view_row_has_child_toggled_cb (GtkTreeModel *model, * gtk_tree_model_filter_refilter (). We add the rows to expand/contract to * a hash table, and expand or contract them as appropriate all at once in * an idle handler which iterates over all the group rows. */ - if (g_hash_table_lookup_extended (priv->expand_groups, name, NULL, - &will_expand) == FALSE || + if (!g_hash_table_lookup_extended (priv->expand_groups, name, NULL, + &will_expand) || GPOINTER_TO_INT (will_expand) != should_expand) { g_hash_table_insert (priv->expand_groups, g_strdup (name), @@ -1637,93 +1643,59 @@ individual_view_row_has_child_toggled_cb (GtkTreeModel *model, g_free (name); } -/* FIXME: This is a workaround for bgo#621076 */ -static void -individual_view_verify_group_visibility (EmpathyIndividualView *view, - GtkTreePath *path) -{ - EmpathyIndividualViewPriv *priv = GET_PRIV (view); - GtkTreeModel *model; - GtkTreePath *parent_path; - GtkTreeIter parent_iter; - - if (gtk_tree_path_get_depth (path) < 2) - return; - - /* A group row is visible if and only if at least one if its child is visible. - * So when a row is inserted/deleted/changed in the base model, that could - * modify the visibility of its parent in the filter model. - */ - - model = GTK_TREE_MODEL (priv->store); - parent_path = gtk_tree_path_copy (path); - gtk_tree_path_up (parent_path); - if (gtk_tree_model_get_iter (model, &parent_iter, parent_path)) - { - /* This tells the filter to verify the visibility of that row, and - * show/hide it if necessary */ - gtk_tree_model_row_changed (GTK_TREE_MODEL (priv->store), - parent_path, &parent_iter); - } - gtk_tree_path_free (parent_path); -} - -static void -individual_view_store_row_changed_cb (GtkTreeModel *model, - GtkTreePath *path, - GtkTreeIter *iter, - EmpathyIndividualView *view) -{ - individual_view_verify_group_visibility (view, path); -} - -static void -individual_view_store_row_deleted_cb (GtkTreeModel *model, - GtkTreePath *path, - EmpathyIndividualView *view) -{ - individual_view_verify_group_visibility (view, path); -} - static gboolean individual_view_is_visible_individual (EmpathyIndividualView *self, FolksIndividual *individual, gboolean is_online, gboolean is_searching, const gchar *group, - gboolean is_fake_group) + gboolean is_fake_group, + guint event_count) { EmpathyIndividualViewPriv *priv = GET_PRIV (self); EmpathyLiveSearch *live = EMPATHY_LIVE_SEARCH (priv->search_widget); - const gchar *str; - GList *personas, *l; - gboolean is_favorite, contains_interesting_persona = FALSE; + GeeSet *personas; + GeeIterator *iter; + gboolean is_favorite; + + /* Always display individuals having pending events */ + if (event_count > 0) + return TRUE; /* We're only giving the visibility wrt filtering here, not things like * presence. */ - if (priv->show_untrusted == FALSE && + if (!priv->show_untrusted && folks_individual_get_trust_level (individual) == FOLKS_TRUST_LEVEL_NONE) { return FALSE; } - /* Hide all individuals which consist entirely of uninteresting personas */ - personas = folks_individual_get_personas (individual); - for (l = personas; l; l = l->next) + if (!priv->show_uninteresting) { - if (empathy_folks_persona_is_interesting (FOLKS_PERSONA (l->data))) + gboolean contains_interesting_persona = FALSE; + + /* Hide all individuals which consist entirely of uninteresting + * personas */ + personas = folks_individual_get_personas (individual); + iter = gee_iterable_iterator (GEE_ITERABLE (personas)); + while (!contains_interesting_persona && gee_iterator_next (iter)) { - contains_interesting_persona = TRUE; - break; + FolksPersona *persona = gee_iterator_get (iter); + + if (empathy_folks_persona_is_interesting (persona)) + contains_interesting_persona = TRUE; + + g_clear_object (&persona); } - } + g_clear_object (&iter); - if (contains_interesting_persona == FALSE) - return FALSE; + if (!contains_interesting_persona) + return FALSE; + } is_favorite = folks_favourite_details_get_is_favourite ( FOLKS_FAVOURITE_DETAILS (individual)); - if (is_searching == FALSE) { + if (!is_searching) { if (is_favorite && is_fake_group && !tp_strdiff (group, EMPATHY_INDIVIDUAL_STORE_FAVORITE)) /* Always display favorite contacts in the favorite group */ @@ -1732,37 +1704,9 @@ individual_view_is_visible_individual (EmpathyIndividualView *self, return (priv->show_offline || is_online); } - /* check alias name */ - str = folks_alias_details_get_alias (FOLKS_ALIAS_DETAILS (individual)); - - if (empathy_live_search_match (live, str)) - return TRUE; - - /* check contact id, remove the @server.com part */ - for (l = personas; l; l = l->next) - { - const gchar *p; - gchar *dup_str = NULL; - gboolean visible; - - if (!empathy_folks_persona_is_interesting (FOLKS_PERSONA (l->data))) - continue; - - str = folks_persona_get_display_id (l->data); - p = strstr (str, "@"); - if (p != NULL) - str = dup_str = g_strndup (str, p - str); - - visible = empathy_live_search_match (live, str); - g_free (dup_str); - if (visible) - return TRUE; - } - - /* FIXME: Add more rules here, we could check phone numbers in - * contact's vCard for example. */ - - return FALSE; + return empathy_individual_match_string (individual, + empathy_live_search_get_text (live), + empathy_live_search_get_words (live)); } static gchar * @@ -1799,6 +1743,10 @@ individual_view_filter_visible_func (GtkTreeModel *model, GtkTreeIter child_iter; gboolean visible, is_online; gboolean is_searching = TRUE; + guint event_count; + + if (priv->custom_filter != NULL) + return priv->custom_filter (model, iter, priv->custom_filter_data); if (priv->search_widget == NULL || !gtk_widget_get_visible (priv->search_widget)) @@ -1809,6 +1757,7 @@ individual_view_filter_visible_func (GtkTreeModel *model, EMPATHY_INDIVIDUAL_STORE_COL_IS_SEPARATOR, &is_separator, EMPATHY_INDIVIDUAL_STORE_COL_IS_ONLINE, &is_online, EMPATHY_INDIVIDUAL_STORE_COL_INDIVIDUAL, &individual, + EMPATHY_INDIVIDUAL_STORE_COL_EVENT_COUNT, &event_count, -1); if (individual != NULL) @@ -1819,19 +1768,11 @@ individual_view_filter_visible_func (GtkTreeModel *model, group = get_group (model, iter, &is_fake_group); visible = individual_view_is_visible_individual (self, individual, - is_online, is_searching, group, is_fake_group); + is_online, is_searching, group, is_fake_group, event_count); g_object_unref (individual); g_free (group); - /* FIXME: Work around bgo#626552/bgo#621076 */ - if (visible == TRUE) - { - GtkTreePath *path = gtk_tree_model_get_path (model, iter); - individual_view_verify_group_visibility (self, path); - gtk_tree_path_free (path); - } - return visible; } @@ -1851,6 +1792,7 @@ individual_view_filter_visible_func (GtkTreeModel *model, gtk_tree_model_get (model, &child_iter, EMPATHY_INDIVIDUAL_STORE_COL_INDIVIDUAL, &individual, EMPATHY_INDIVIDUAL_STORE_COL_IS_ONLINE, &is_online, + EMPATHY_INDIVIDUAL_STORE_COL_EVENT_COUNT, &event_count, -1); if (individual == NULL) @@ -1859,13 +1801,13 @@ individual_view_filter_visible_func (GtkTreeModel *model, group = get_group (model, &child_iter, &is_fake_group); visible = individual_view_is_visible_individual (self, individual, - is_online, is_searching, group, is_fake_group); + is_online, is_searching, group, is_fake_group, event_count); g_object_unref (individual); g_free (group); /* show group if it has at least one visible contact in it */ - if (visible == TRUE) + if (visible) return TRUE; } @@ -2057,7 +1999,7 @@ individual_view_finalize (GObject *object) if (priv->expand_groups_idle_handler != 0) g_source_remove (priv->expand_groups_idle_handler); - g_hash_table_destroy (priv->expand_groups); + g_hash_table_unref (priv->expand_groups); G_OBJECT_CLASS (empathy_individual_view_parent_class)->finalize (object); } @@ -2089,6 +2031,9 @@ individual_view_get_property (GObject *object, case PROP_SHOW_UNTRUSTED: g_value_set_boolean (value, priv->show_untrusted); break; + case PROP_SHOW_UNINTERESTING: + g_value_set_boolean (value, priv->show_uninteresting); + break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, param_id, pspec); break; @@ -2123,6 +2068,9 @@ individual_view_set_property (GObject *object, empathy_individual_view_set_show_untrusted (view, g_value_get_boolean (value)); break; + case PROP_SHOW_UNINTERESTING: + empathy_individual_view_set_show_uninteresting (view, + g_value_get_boolean (value)); default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, param_id, pspec); break; @@ -2162,7 +2110,7 @@ empathy_individual_view_class_init (EmpathyIndividualViewClass *klass) G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (EmpathyIndividualViewClass, drag_individual_received), NULL, NULL, - _empathy_gtk_marshal_VOID__UINT_OBJECT_STRING_STRING, + g_cclosure_marshal_generic, G_TYPE_NONE, 4, G_TYPE_UINT, FOLKS_TYPE_INDIVIDUAL, G_TYPE_STRING, G_TYPE_STRING); @@ -2172,7 +2120,7 @@ empathy_individual_view_class_init (EmpathyIndividualViewClass *klass) G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (EmpathyIndividualViewClass, drag_persona_received), NULL, NULL, - _empathy_gtk_marshal_BOOLEAN__UINT_OBJECT_OBJECT, + g_cclosure_marshal_generic, G_TYPE_BOOLEAN, 3, G_TYPE_UINT, FOLKS_TYPE_PERSONA, FOLKS_TYPE_INDIVIDUAL); g_object_class_install_property (object_class, @@ -2209,6 +2157,13 @@ empathy_individual_view_class_init (EmpathyIndividualViewClass *klass) "Whether the view should display untrusted individuals; " "those who could not be who they say they are.", TRUE, G_PARAM_READWRITE)); + g_object_class_install_property (object_class, + PROP_SHOW_UNINTERESTING, + g_param_spec_boolean ("show-uninteresting", + "Show Uninteresting Individuals", + "Whether the view should not filter out individuals using " + "empathy_folks_persona_is_interesting.", + FALSE, G_PARAM_READWRITE)); g_type_class_add_private (object_class, sizeof (EmpathyIndividualViewPriv)); } @@ -2222,6 +2177,7 @@ empathy_individual_view_init (EmpathyIndividualView *view) view->priv = priv; priv->show_untrusted = TRUE; + priv->show_uninteresting = FALSE; /* Get saved group states. */ empathy_contact_groups_get_all (); @@ -2463,11 +2419,12 @@ got_avatar (GObject *source_object, { FolksIndividual *individual = FOLKS_INDIVIDUAL (source_object); EmpathyIndividualView *view = user_data; + EmpathyIndividualViewPriv *priv = GET_PRIV (view); GdkPixbuf *avatar; EmpathyIndividualManager *manager; gchar *text; GtkWindow *parent; - GList *l, *personas; + GeeSet *personas; guint persona_count = 0; gboolean can_block; GError *error = NULL; @@ -2487,19 +2444,31 @@ got_avatar (GObject *source_object, personas = folks_individual_get_personas (individual); - /* If we have more than one TpfPersona, display a different message - * ensuring the user knows that *all* of the meta-contacts' personas will - * be removed. */ - for (l = personas; l != NULL; l = l->next) + if (priv->show_uninteresting) { - if (!empathy_folks_persona_is_interesting (FOLKS_PERSONA (l->data))) - continue; + persona_count = gee_collection_get_size (GEE_COLLECTION (personas)); + } + else + { + GeeIterator *iter; - persona_count++; - if (persona_count >= 2) - break; + iter = gee_iterable_iterator (GEE_ITERABLE (personas)); + while (persona_count < 2 && gee_iterator_next (iter)) + { + FolksPersona *persona = gee_iterator_get (iter); + + if (empathy_folks_persona_is_interesting (persona)) + persona_count++; + + g_clear_object (&persona); + } + g_clear_object (&iter); } + /* If we have more than one TpfPersona, display a different message + * ensuring the user knows that *all* of the meta-contacts' personas will + * be removed. */ + if (persona_count < 2) { /* Not a meta-contact */ @@ -2590,33 +2559,44 @@ empathy_individual_view_get_individual_menu (EmpathyIndividualView *view) GtkWidget *item; GtkWidget *image; gboolean can_remove = FALSE; - GList *l; + GeeSet *personas; + GeeIterator *iter; g_return_val_if_fail (EMPATHY_IS_INDIVIDUAL_VIEW (view), NULL); + if (priv->individual_features == EMPATHY_INDIVIDUAL_FEATURE_NONE) + /* No need to create a context menu */ + return NULL; + individual = empathy_individual_view_dup_selected (view); if (individual == NULL) return NULL; + if (!empathy_folks_individual_contains_contact (individual)) + goto out; + /* If any of the Individual's personas can be removed, add an option to * remove. This will act as a best-effort option. If any Personas cannot be * removed from the server, then this option will just be inactive upon * subsequent menu openings */ - for (l = folks_individual_get_personas (individual); l != NULL; l = l->next) + personas = folks_individual_get_personas (individual); + iter = gee_iterable_iterator (GEE_ITERABLE (personas)); + while (!can_remove && gee_iterator_next (iter)) { - FolksPersona *persona = FOLKS_PERSONA (l->data); + FolksPersona *persona = gee_iterator_get (iter); FolksPersonaStore *store = folks_persona_get_store (persona); FolksMaybeBool maybe_can_remove = folks_persona_store_get_can_remove_personas (store); if (maybe_can_remove == FOLKS_MAYBE_BOOL_TRUE) - { - can_remove = TRUE; - break; - } + can_remove = TRUE; + + g_clear_object (&persona); } + g_clear_object (&iter); - menu = empathy_individual_menu_new (individual, priv->individual_features); + menu = empathy_individual_menu_new (individual, priv->individual_features, + priv->store); /* Remove contact */ if ((priv->view_features & @@ -2650,6 +2630,7 @@ empathy_individual_view_get_individual_menu (EmpathyIndividualView *view) g_signal_connect (menu, "link-contacts-activated", (GCallback) individual_menu_link_contacts_activated_cb, view); +out: g_object_unref (individual); return menu; @@ -2789,11 +2770,6 @@ empathy_individual_view_set_store (EmpathyIndividualView *self, /* Destroy the old filter and remove the old store */ if (priv->store != NULL) { - g_signal_handlers_disconnect_by_func (priv->store, - individual_view_store_row_changed_cb, self); - g_signal_handlers_disconnect_by_func (priv->store, - individual_view_store_row_deleted_cb, self); - g_signal_handlers_disconnect_by_func (priv->filter, individual_view_row_has_child_toggled_cb, self); @@ -2820,13 +2796,6 @@ empathy_individual_view_set_store (EmpathyIndividualView *self, G_CALLBACK (individual_view_row_has_child_toggled_cb), self); gtk_tree_view_set_model (GTK_TREE_VIEW (self), GTK_TREE_MODEL (priv->filter)); - - tp_g_signal_connect_object (priv->store, "row-changed", - G_CALLBACK (individual_view_store_row_changed_cb), self, 0); - tp_g_signal_connect_object (priv->store, "row-inserted", - G_CALLBACK (individual_view_store_row_changed_cb), self, 0); - tp_g_signal_connect_object (priv->store, "row-deleted", - G_CALLBACK (individual_view_store_row_deleted_cb), self, 0); } } @@ -2843,3 +2812,55 @@ empathy_individual_view_start_search (EmpathyIndividualView *self) else gtk_widget_show (GTK_WIDGET (priv->search_widget)); } + +void +empathy_individual_view_set_custom_filter (EmpathyIndividualView *self, + GtkTreeModelFilterVisibleFunc filter, + gpointer data) +{ + EmpathyIndividualViewPriv *priv = GET_PRIV (self); + + priv->custom_filter = filter; + priv->custom_filter_data = data; +} + +void +empathy_individual_view_refilter (EmpathyIndividualView *self) +{ + EmpathyIndividualViewPriv *priv = GET_PRIV (self); + + gtk_tree_model_filter_refilter (priv->filter); +} + +void +empathy_individual_view_select_first (EmpathyIndividualView *self) +{ + EmpathyIndividualViewPriv *priv = GET_PRIV (self); + GtkTreeIter iter; + + gtk_tree_model_filter_refilter (priv->filter); + + if (gtk_tree_model_get_iter_first (GTK_TREE_MODEL (priv->filter), &iter)) + { + GtkTreeSelection *selection = gtk_tree_view_get_selection ( + GTK_TREE_VIEW (self)); + + gtk_tree_selection_select_iter (selection, &iter); + } +} + +void +empathy_individual_view_set_show_uninteresting (EmpathyIndividualView *self, + gboolean show_uninteresting) +{ + EmpathyIndividualViewPriv *priv; + + g_return_if_fail (EMPATHY_IS_INDIVIDUAL_VIEW (self)); + + priv = GET_PRIV (self); + + priv->show_uninteresting = show_uninteresting; + + g_object_notify (G_OBJECT (self), "show-uninteresting"); + gtk_tree_model_filter_refilter (priv->filter); +}