]> git.0d.be Git - empathy.git/blobdiff - libempathy-gtk/empathy-contact-list-store.c
Merge branch 'people-nearby-fake-group-613558'
[empathy.git] / libempathy-gtk / empathy-contact-list-store.c
index 21593932f1af01d6b03927ea40ce33d5b6530e11..6b35b082440ab1835f2f35578828a1eb4bec67b7 100644 (file)
@@ -147,7 +147,8 @@ static void             contact_list_store_get_group                 (EmpathyCon
                                                                      const gchar                   *name,
                                                                      GtkTreeIter                   *iter_group_to_set,
                                                                      GtkTreeIter                   *iter_separator_to_set,
-                                                                     gboolean                      *created);
+                                                                     gboolean                      *created,
+                                                                     gboolean                      is_fake_group);
 static gint             contact_list_store_state_sort_func           (GtkTreeModel                  *model,
                                                                      GtkTreeIter                   *iter_a,
                                                                      GtkTreeIter                   *iter_b,
@@ -727,11 +728,13 @@ empathy_contact_list_store_row_separator_func (GtkTreeModel *model,
 gchar *
 empathy_contact_list_store_get_parent_group (GtkTreeModel *model,
                                            GtkTreePath  *path,
-                                           gboolean     *path_is_group)
+                                           gboolean     *path_is_group,
+                                           gboolean     *is_fake_group)
 {
        GtkTreeIter  parent_iter, iter;
        gchar       *name = NULL;
        gboolean     is_group;
+       gboolean     fake;
 
        g_return_val_if_fail (GTK_IS_TREE_MODEL (model), NULL);
 
@@ -761,6 +764,7 @@ empathy_contact_list_store_get_parent_group (GtkTreeModel *model,
                gtk_tree_model_get (model, &iter,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_GROUP, &is_group,
                                    EMPATHY_CONTACT_LIST_STORE_COL_NAME, &name,
+                                   EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, &fake,
                                    -1);
                if (!is_group) {
                        g_free (name);
@@ -772,6 +776,9 @@ empathy_contact_list_store_get_parent_group (GtkTreeModel *model,
                *path_is_group = TRUE;
        }
 
+       if (is_fake_group != NULL)
+               *is_fake_group = fake;
+
        return name;
 }
 
@@ -826,8 +833,9 @@ contact_list_store_setup (EmpathyContactListStore *store)
                GDK_TYPE_PIXBUF,      /* Avatar pixbuf */
                G_TYPE_BOOLEAN,       /* Avatar pixbuf visible */
                G_TYPE_STRING,        /* Name */
+               G_TYPE_UINT,          /* Presence type */
                G_TYPE_STRING,        /* Status string */
-               G_TYPE_BOOLEAN,       /* Show status */
+               G_TYPE_BOOLEAN,       /* Compact view */
                EMPATHY_TYPE_CONTACT, /* Contact type */
                G_TYPE_BOOLEAN,       /* Is group */
                G_TYPE_BOOLEAN,       /* Is active */
@@ -836,7 +844,7 @@ contact_list_store_setup (EmpathyContactListStore *store)
                G_TYPE_BOOLEAN,       /* Can make audio calls */
                G_TYPE_BOOLEAN,       /* Can make video calls */
                EMPATHY_TYPE_CONTACT_LIST_FLAGS, /* Flags */
-               G_TYPE_BOOLEAN,       /* Is a favourite */
+               G_TYPE_BOOLEAN,       /* Is a fake group */
        };
 
        priv = GET_PRIV (store);
@@ -929,25 +937,6 @@ contact_list_store_members_changed_cb (EmpathyContactList      *list_iface,
        }
 }
 
-static void
-contact_list_store_change_contact_favourite_status (EmpathyContactListStore *store,
-                                                   EmpathyContact          *contact,
-                                                   gboolean                 is_favourite)
-{
-       GList *iters, *l;
-
-       iters = contact_list_store_find_contact (store, contact);
-       for (l = iters; l; l = l->next) {
-               gtk_tree_store_set (GTK_TREE_STORE (store), l->data,
-                       EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE,
-                       is_favourite,
-                       -1);
-       }
-
-       g_list_foreach (iters, (GFunc) gtk_tree_iter_free, NULL);
-       g_list_free (iters);
-}
-
 static void
 contact_list_store_favourites_changed_cb (EmpathyContactList      *list_iface,
                                          EmpathyContact          *contact,
@@ -963,8 +952,8 @@ contact_list_store_favourites_changed_cb (EmpathyContactList      *list_iface,
                empathy_contact_get_handle (contact),
                is_favourite ? "now" : "no longer");
 
-       contact_list_store_change_contact_favourite_status (store, contact,
-                                                                                                                                                                                                     is_favourite);
+       contact_list_store_remove_contact (store, contact);
+       contact_list_store_add_contact (store, contact);
 }
 
 static void
@@ -1049,6 +1038,7 @@ contact_list_store_add_contact (EmpathyContactListStore *store,
        GList                      *groups = NULL, *l;
        TpConnection               *connection;
        EmpathyContactListFlags     flags = 0;
+       char                       *protocol_name;
 
        priv = GET_PRIV (store);
 
@@ -1066,12 +1056,23 @@ contact_list_store_add_contact (EmpathyContactListStore *store,
                flags = empathy_contact_manager_get_flags_for_connection (
                        EMPATHY_CONTACT_MANAGER (priv->list), connection);
        }
+
+       tp_connection_parse_object_path (connection, &protocol_name, NULL);
+
        if (!groups) {
 #if HAVE_FAVOURITE_CONTACTS
                GtkTreeIter iter_group;
 
-               contact_list_store_get_group (store, EMPATHY_CONTACT_LIST_STORE_UNGROUPED,
-                       &iter_group, NULL, NULL);
+               if (!tp_strdiff (protocol_name, "local-xmpp")) {
+                       /* these are People Nearby */
+                       contact_list_store_get_group (store,
+                               EMPATHY_CONTACT_LIST_STORE_PEOPLE_NEARBY,
+                               &iter_group, NULL, NULL, TRUE);
+               } else {
+                       contact_list_store_get_group (store,
+                               EMPATHY_CONTACT_LIST_STORE_UNGROUPED,
+                               &iter_group, NULL, NULL, TRUE);
+               }
 
                gtk_tree_store_insert_after (GTK_TREE_STORE (store), &iter,
                                             &iter_group, NULL);
@@ -1101,11 +1102,13 @@ contact_list_store_add_contact (EmpathyContactListStore *store,
                add_contact_to_store (GTK_TREE_STORE (store), &iter, contact, flags);
        }
 
+       g_free (protocol_name);
+
        /* Else add to each group. */
        for (l = groups; l; l = l->next) {
                GtkTreeIter iter_group;
 
-               contact_list_store_get_group (store, l->data, &iter_group, NULL, NULL);
+               contact_list_store_get_group (store, l->data, &iter_group, NULL, NULL, FALSE);
 
                gtk_tree_store_insert_after (GTK_TREE_STORE (store), &iter,
                                             &iter_group, NULL);
@@ -1115,8 +1118,22 @@ contact_list_store_add_contact (EmpathyContactListStore *store,
        }
        g_list_free (groups);
 
-       contact_list_store_contact_update (store, contact);
+#ifdef HAVE_FAVOURITE_CONTACTS
+       if (empathy_contact_list_is_favourite (priv->list, contact)) {
+       /* Add contact to the fake 'Favorites' group */
+               GtkTreeIter iter_group;
 
+               contact_list_store_get_group (store, EMPATHY_CONTACT_LIST_STORE_FAVORITE,
+                       &iter_group, NULL, NULL, TRUE);
+
+               gtk_tree_store_insert_after (GTK_TREE_STORE (store), &iter,
+                                            &iter_group, NULL);
+
+               add_contact_to_store (GTK_TREE_STORE (store), &iter, contact, flags);
+       }
+#endif
+
+       contact_list_store_contact_update (store, contact);
 }
 
 static void
@@ -1156,17 +1173,6 @@ contact_list_store_remove_contact (EmpathyContactListStore *store,
        g_list_free (iters);
 }
 
-static gboolean
-list_store_contact_is_favourite (EmpathyContactListStore *store,
-                                EmpathyContact          *contact)
-{
-       EmpathyContactListStorePriv *priv;
-
-       priv = GET_PRIV (store);
-
-       return empathy_contact_list_is_favourite (priv->list, contact);
-}
-
 static void
 contact_list_store_contact_update (EmpathyContactListStore *store,
                                   EmpathyContact          *contact)
@@ -1282,13 +1288,15 @@ contact_list_store_contact_update (EmpathyContactListStore *store,
        pixbuf_status = contact_list_store_get_contact_status_icon (store, contact);
        for (l = iters; l && set_model; l = l->next) {
                gtk_tree_store_set (GTK_TREE_STORE (store), l->data,
-                                   EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE, list_store_contact_is_favourite (store, contact),
                                    EMPATHY_CONTACT_LIST_STORE_COL_ICON_STATUS, pixbuf_status,
                                    EMPATHY_CONTACT_LIST_STORE_COL_PIXBUF_AVATAR, pixbuf_avatar,
                                    EMPATHY_CONTACT_LIST_STORE_COL_PIXBUF_AVATAR_VISIBLE, show_avatar,
                                    EMPATHY_CONTACT_LIST_STORE_COL_NAME, empathy_contact_get_name (contact),
-                                   EMPATHY_CONTACT_LIST_STORE_COL_STATUS, empathy_contact_get_status (contact),
-                                   EMPATHY_CONTACT_LIST_STORE_COL_STATUS_VISIBLE, !priv->is_compact,
+                                   EMPATHY_CONTACT_LIST_STORE_COL_PRESENCE_TYPE,
+                                     empathy_contact_get_presence (contact),
+                                   EMPATHY_CONTACT_LIST_STORE_COL_STATUS,
+                                     empathy_contact_get_presence_message (contact),
+                                   EMPATHY_CONTACT_LIST_STORE_COL_COMPACT, priv->is_compact,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_GROUP, FALSE,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_ONLINE, now_online,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, FALSE,
@@ -1462,7 +1470,8 @@ contact_list_store_get_group (EmpathyContactListStore *store,
                              const gchar            *name,
                              GtkTreeIter            *iter_group_to_set,
                              GtkTreeIter            *iter_separator_to_set,
-                             gboolean               *created)
+                             gboolean               *created,
+                             gboolean               is_fake_group)
 {
        EmpathyContactListStorePriv *priv;
        GtkTreeModel                *model;
@@ -1493,6 +1502,7 @@ contact_list_store_get_group (EmpathyContactListStore *store,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_GROUP, TRUE,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_ACTIVE, FALSE,
                                    EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, FALSE,
+                                   EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, is_fake_group,
                                    -1);
 
                if (iter_group_to_set) {
@@ -1534,16 +1544,42 @@ contact_list_store_get_group (EmpathyContactListStore *store,
        }
 }
 
+static gint
+get_position (const char **strv,
+             const char *str)
+{
+       int i;
+
+       for (i = 0; strv[i] != NULL; i++) {
+               if (!tp_strdiff (strv[i], str))
+                       return i;
+       }
+
+       return -1;
+}
+
 static gint
 compare_separator_and_groups (gboolean is_separator_a,
                              gboolean is_separator_b,
-                             gboolean is_favourite_a,
-                             gboolean is_favourite_b,
                              const gchar *name_a,
                              const gchar *name_b,
                              EmpathyContact *contact_a,
-                             EmpathyContact *contact_b)
+                             EmpathyContact *contact_b,
+                             gboolean fake_group_a,
+                             gboolean fake_group_b)
 {
+       /* these two lists are the sorted list of fake groups to include at the
+        * top and bottom of the roster */
+       const char *top_groups[] = {
+               EMPATHY_CONTACT_LIST_STORE_FAVORITE,
+               NULL
+       };
+
+       const char *bottom_groups[] = {
+               EMPATHY_CONTACT_LIST_STORE_UNGROUPED,
+               NULL
+       };
+
        if (is_separator_a || is_separator_b) {
                /* We have at least one separator */
                if (is_separator_a) {
@@ -1553,25 +1589,40 @@ compare_separator_and_groups (gboolean is_separator_a,
                }
        }
 
-       /* Favorites are displayed first */
-       if (is_favourite_a && !is_favourite_b) {
-               return -1;
-       } else if (!is_favourite_a && is_favourite_b) {
-               return 1;
        /* One group and one contact */
-       } else if (!contact_a && contact_b) {
+       if (!contact_a && contact_b) {
                return 1;
        } else if (contact_a && !contact_b) {
                return -1;
        } else if (!contact_a && !contact_b) {
-               /* Two groups. The 'Ungrouped' fake group is display at the bottom of the
-                * contact list. */
-               if (!tp_strdiff (name_a, EMPATHY_CONTACT_LIST_STORE_UNGROUPED))
-                       return 1;
-               else if (!tp_strdiff (name_b, EMPATHY_CONTACT_LIST_STORE_UNGROUPED))
+               gboolean a_in_top, b_in_top, a_in_bottom, b_in_bottom;
+
+               a_in_top = fake_group_a &&
+                       tp_strv_contains (top_groups, name_a);
+               b_in_top = fake_group_b &&
+                       tp_strv_contains (top_groups, name_b);
+               a_in_bottom = fake_group_b &&
+                       tp_strv_contains (bottom_groups, name_a);
+               b_in_bottom = fake_group_b &&
+                       tp_strv_contains (bottom_groups, name_b);
+
+               if (a_in_top && b_in_top) {
+                       /* compare positions */
+                       return CLAMP (get_position (top_groups, name_a) -
+                                     get_position (top_groups, name_b),
+                                     -1, 1);
+               } else if (a_in_bottom && b_in_bottom) {
+                       /* compare positions */
+                       return CLAMP (get_position (bottom_groups, name_a) -
+                                     get_position (bottom_groups, name_b),
+                                     -1, 1);
+               } else if (a_in_top || b_in_bottom) {
                        return -1;
-               else
+               } else if (b_in_top || a_in_bottom) {
+                       return 1;
+               } else {
                        return g_utf8_collate (name_a, name_b);
+               }
        }
 
        /* Two contacts, ordering depends of the sorting policy */
@@ -1587,24 +1638,24 @@ contact_list_store_state_sort_func (GtkTreeModel *model,
        gint            ret_val;
        gchar          *name_a, *name_b;
        gboolean        is_separator_a, is_separator_b;
-       gboolean        is_favourite_a, is_favourite_b;
        EmpathyContact *contact_a, *contact_b;
+       gboolean       fake_group_a, fake_group_b;
 
        gtk_tree_model_get (model, iter_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_NAME, &name_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_CONTACT, &contact_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, &is_separator_a,
-                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE, &is_favourite_a,
+                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, &fake_group_a,
                            -1);
        gtk_tree_model_get (model, iter_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_NAME, &name_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_CONTACT, &contact_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, &is_separator_b,
-                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE, &is_favourite_b,
+                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, &fake_group_b,
                            -1);
 
        ret_val = compare_separator_and_groups (is_separator_a, is_separator_b,
-               is_favourite_a, is_favourite_b, name_a, name_b, contact_a, contact_b);
+               name_a, name_b, contact_a, contact_b, fake_group_a, fake_group_b);
 
        if (ret_val != 0) {
                goto free_and_out;
@@ -1646,24 +1697,24 @@ contact_list_store_name_sort_func (GtkTreeModel *model,
        gchar         *name_a, *name_b;
        EmpathyContact *contact_a, *contact_b;
        gboolean       is_separator_a = FALSE, is_separator_b = FALSE;
-       gboolean       is_favourite_a, is_favourite_b;
        gint           ret_val;
+       gboolean       fake_group_a, fake_group_b;
 
        gtk_tree_model_get (model, iter_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_NAME, &name_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_CONTACT, &contact_a,
                            EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, &is_separator_a,
-                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE, &is_favourite_a,
+                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, &fake_group_a,
                            -1);
        gtk_tree_model_get (model, iter_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_NAME, &name_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_CONTACT, &contact_b,
                            EMPATHY_CONTACT_LIST_STORE_COL_IS_SEPARATOR, &is_separator_b,
-                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAVOURITE, &is_favourite_b,
+                           EMPATHY_CONTACT_LIST_STORE_COL_IS_FAKE_GROUP, &fake_group_b,
                            -1);
 
        ret_val = compare_separator_and_groups (is_separator_a, is_separator_b,
-               is_favourite_a, is_favourite_b, name_a, name_b, contact_a, contact_b);
+               name_a, name_b, contact_a, contact_b, fake_group_a, fake_group_b);
 
        if (ret_val == 0)
                ret_val = g_utf8_collate (name_a, name_b);
@@ -1760,7 +1811,7 @@ contact_list_store_update_list_mode_foreach (GtkTreeModel           *model,
        gtk_tree_store_set (GTK_TREE_STORE (store), iter,
                            EMPATHY_CONTACT_LIST_STORE_COL_ICON_STATUS, pixbuf_status,
                            EMPATHY_CONTACT_LIST_STORE_COL_PIXBUF_AVATAR_VISIBLE, show_avatar,
-                           EMPATHY_CONTACT_LIST_STORE_COL_STATUS_VISIBLE, !priv->is_compact,
+                           EMPATHY_CONTACT_LIST_STORE_COL_COMPACT, priv->is_compact,
                            -1);
 
        return FALSE;